Set ContentCache for created AnalysisContext(s) to control its view of the world.

Set ContentCache for created AnalysisContext(s) to control its view of the world.

This should help to avoid inconsistency exceptions during Quick Fixes,
when we attempt to match element models created for a source with overlay,
and AST that AnalysisContext created for the content without overlay.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/305d0dff8934efbbc120250b9db4397fba0b38c1

[Paul Berry, 2017-01-04 20:50:50]

lgtm

https://codereview.chromium.org/2617433003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2617433003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1545: return getExists(source) ?
0 : -1;
Since the contract for `getExists` says it might return `null`, it's not obvious
why this is safe.  Consider adding a quick comment here explaining that this is
safe because our override of `getExists` never returns `null`.

[scheglov, 2017-01-04 20:55:52]

Description was changed from

==========
Set ContentCache for created AnalysisContext(s) to control its view of the
world.

This should help to avoid inconsistency exceptions during Quick Fixes,
when we attempt to match element models created for a source with overlay,
and AST that AnalysisContext created for the content without overlay.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Set ContentCache for created AnalysisContext(s) to control its view of the
world.

This should help to avoid inconsistency exceptions during Quick Fixes,
when we attempt to match element models created for a source with overlay,
and AST that AnalysisContext created for the content without overlay.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/305d0dff8934efbbc120250b9db4397fba0b38c1
==========

[scheglov, 2017-01-04 20:55:53]

Committed patchset #1 (id:1) manually as
305d0dff8934efbbc120250b9db4397fba0b38c1 (presubmit successful).

[Brian Wilkerson, 2017-01-04 20:59:36]

lgtm