Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chromeos/process_proxy/process_proxy_unittest.cc

Issue 261743002: Improve process output watcher's handling of multi-byte UTF8 characters (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/process_proxy/process_output_watcher_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtest/gtest.h> 5 #include <gtest/gtest.h>
6 6
7 #include <string> 7 #include <string>
8 #include <sys/wait.h>
9 8
10 #include "base/bind.h" 9 #include "base/bind.h"
11 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
12 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
13 #include "base/process/kill.h" 12 #include "base/process/kill.h"
14 #include "base/synchronization/waitable_event.h"
15 #include "base/threading/thread.h" 13 #include "base/threading/thread.h"
16 #include "chromeos/process_proxy/process_proxy_registry.h" 14 #include "chromeos/process_proxy/process_proxy_registry.h"
17 15
18 namespace chromeos { 16 namespace chromeos {
19 17
20 namespace { 18 namespace {
21 19
22 // The test line must have all distinct characters. 20 // The test line must have all distinct characters.
23 const char kTestLineToSend[] = "abcdefgh\n"; 21 const char kTestLineToSend[] = "abcdefgh\n";
24 const char kTestLineExpected[] = "abcdefgh\r\n"; 22 const char kTestLineExpected[] = "abcdefgh\r\n";
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 } 245 }
248 246
249 // Test verifies that \003 message send to process is processed as SigInt. 247 // Test verifies that \003 message send to process is processed as SigInt.
250 // Timing out on the waterfall: http://crbug.com/115064 248 // Timing out on the waterfall: http://crbug.com/115064
251 TEST_F(ProcessProxyTest, DISABLED_SigInt) { 249 TEST_F(ProcessProxyTest, DISABLED_SigInt) {
252 test_runner_.reset(new SigIntTestRunner()); 250 test_runner_.reset(new SigIntTestRunner());
253 RunTest(); 251 RunTest();
254 } 252 }
255 253
256 } // namespace chromeos 254 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/process_proxy/process_output_watcher_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698