Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm

Issue 2617393003: [ios] EarlGrey tests for HTTP Authentication. (Closed)
Patch Set: Actually disabled tests on iPad Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
diff --git a/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm b/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
index ffc45089a7cc55abf25a4c7475718ac3911cfa13..0be5b1267ef61b117d479c597c26c930f2c0f33c 100644
--- a/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
+++ b/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
@@ -239,9 +239,8 @@ void TapOK() {
}
void TapCancel() {
- id<GREYMatcher> cancel_button =
- chrome_test_util::buttonWithAccessibilityLabelId(IDS_CANCEL);
- [[EarlGrey selectElementWithMatcher:cancel_button] performAction:grey_tap()];
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::cancelButton()]
+ performAction:grey_tap()];
}
void TapSuppressDialogsButton() {
@@ -282,10 +281,9 @@ void TapSuppressDialogsButton() {
NSError* errorCancel = nil;
// Dismiss JavaScript alert by tapping Cancel.
- id<GREYMatcher> CancelButton =
- chrome_test_util::buttonWithAccessibilityLabelId(IDS_CANCEL);
- [[EarlGrey selectElementWithMatcher:CancelButton] performAction:grey_tap()
- error:&errorCancel];
+ [[EarlGrey selectElementWithMatcher:chrome_test_util::cancelButton()]
+ performAction:grey_tap()
+ error:&errorCancel];
// Dismiss JavaScript alert by tapping OK.
id<GREYMatcher> OKButton =
chrome_test_util::buttonWithAccessibilityLabelId(IDS_OK);
« no previous file with comments | « no previous file | ios/chrome/browser/ui/toolbar/toolbar_egtest.mm » ('j') | ios/chrome/browser/web/http_auth_egtest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698