Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)
Patch Set: [Devtools] Removed getters/setters for NetworkRequest requestId Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html b/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
index ec1d320fd02ccbdd626222e13f7f7c27d9e3c4e1..16ecdf6abce2a6f738a5e23ac159c6954257557c 100644
--- a/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
+++ b/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
@@ -13,33 +13,33 @@ function test() {
var requestFoo = new SDK.NetworkRequest(SDK.targetManager.mainTarget(), "", "", "", "", "");
requestFoo.setResourceType(types.Script);
- requestFoo.requestId = "foo";
+ requestFoo.setRequestId("foo");
target._appendRequest(requestFoo);
var requestBar = new SDK.NetworkRequest(SDK.targetManager.mainTarget(), "", "", "", "", "");
requestBar.setResourceType(types.Script);
- requestBar.requestId = "bar";
+ requestBar.setRequestId("bar");
target._appendRequest(requestBar);
target._refresh();
function isFilteredOut(request) {
- return !!target._nodesByRequestId.get(request.requestId)[Network.NetworkLogView._isFilteredOutSymbol];
+ return !!target._nodesByRequestId.get(request.requestId())[Network.NetworkLogView._isFilteredOutSymbol];
}
InspectorTest.addResult("");
- InspectorTest.addResult("Request [" + requestFoo.requestId + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));
- InspectorTest.addResult("Request [" + requestBar.requestId + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));
+ InspectorTest.addResult("Request [" + requestFoo.requestId() + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));
+ InspectorTest.addResult("Request [" + requestBar.requestId() + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));
InspectorTest.addResult("");
requestFoo.setResourceType(types.XHR);
target._refreshRequest(requestFoo);
- InspectorTest.addResult("Updated request [" + requestFoo.requestId + "] type.");
+ InspectorTest.addResult("Updated request [" + requestFoo.requestId() + "] type.");
target._refreshRequest(requestBar);
- InspectorTest.addResult("Updated request [" + requestBar.requestId + "].");
+ InspectorTest.addResult("Updated request [" + requestBar.requestId() + "].");
target._refresh();
InspectorTest.addResult("");
- InspectorTest.addResult("Request [" + requestFoo.requestId + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));
- InspectorTest.addResult("Request [" + requestBar.requestId + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));
+ InspectorTest.addResult("Request [" + requestFoo.requestId() + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));
+ InspectorTest.addResult("Request [" + requestBar.requestId() + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));
InspectorTest.completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698