Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)
Patch Set: Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
index 4dbbcc9b8a5162f39d6c7b8b734cbeaf445ac20f..b97c3afe22c0bbaf328b2aad425b121002c4b1e3 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -109,14 +109,14 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
/**
* @return {!Protocol.Network.RequestId}
*/
- get requestId() {
+ requestId() {
return this._requestId;
}
/**
* @param {!Protocol.Network.RequestId} requestId
*/
- set requestId(requestId) {
+ setRequestId(requestId) {
this._requestId = requestId;
}
@@ -1174,7 +1174,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
}
replayXHR() {
- this.target().networkAgent().replayXHR(this.requestId);
+ this.target().networkAgent().replayXHR(this._requestId);
}
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698