[Devtools] Removed getters/setters for NetworkRequest requestId

third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 108 matching lines @@
     // Preserve requests from the new session.
     this._currentPageLoad = null;
     var oldRequests = this._requests.splice(0, this._requests.length);
     this._requestForId = {};
     for (var i = 0; i < oldRequests.length; ++i) {
       var request = oldRequests[i];
       if (request.loaderId === mainFrame.loaderId) {
         if (!this._currentPageLoad)
           this._currentPageLoad = new SDK.PageLoad(request);
         this._requests.push(request);
         this._requestForId[request.requestId] = request;

[luoe, 2017/01/09 20:23:00]

Should this use the getter "this._requestForId[request.requestId()]"?

[dgozman, 2017/01/09 21:43:34]

+1

         request.__page = this._currentPageLoad;
       }
     }
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onRequestStarted(event) {
     var request = /** @type {!SDK.NetworkRequest} */ (event.data);
     this._requests.push(request);
-    this._requestForId[request.requestId] = request;
+    this._requestForId[request.requestId()] = request;
     request.__page = this._currentPageLoad;
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onDOMContentLoaded(event) {
     if (this._currentPageLoad)
       this._currentPageLoad.contentLoadTime = event.data;
   }
@@ skipping 24 matching lines @@
    * @param {!SDK.NetworkRequest} mainRequest
    */
   constructor(mainRequest) {
     this.id = ++SDK.PageLoad._lastIdentifier;
     this.url = mainRequest.url;
     this.startTime = mainRequest.startTime;
   }
 };
 
 SDK.PageLoad._lastIdentifier = 0;