Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2617283003: [Devtools] Removed getters/setters for NetworkRequest requestId (Closed)
Patch Set: Merge branch 'TYPE_OBJECT_JS' into REMOVE_GETTERS_SETTERS_1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 if (this._requestId > other._requestId) 102 if (this._requestId > other._requestId)
103 return 1; 103 return 1;
104 if (this._requestId < other._requestId) 104 if (this._requestId < other._requestId)
105 return -1; 105 return -1;
106 return 0; 106 return 0;
107 } 107 }
108 108
109 /** 109 /**
110 * @return {!Protocol.Network.RequestId} 110 * @return {!Protocol.Network.RequestId}
111 */ 111 */
112 get requestId() { 112 requestId() {
113 return this._requestId; 113 return this._requestId;
114 } 114 }
115 115
116 /** 116 /**
117 * @param {!Protocol.Network.RequestId} requestId 117 * @param {!Protocol.Network.RequestId} requestId
118 */ 118 */
119 set requestId(requestId) { 119 setRequestId(requestId) {
120 this._requestId = requestId; 120 this._requestId = requestId;
121 } 121 }
122 122
123 /** 123 /**
124 * @return {string} 124 * @return {string}
125 */ 125 */
126 get url() { 126 get url() {
127 return this._url; 127 return this._url;
128 } 128 }
129 129
(...skipping 1037 matching lines...) Expand 10 before | Expand all | Expand 10 after
1167 * @param {string} eventId 1167 * @param {string} eventId
1168 * @param {string} data 1168 * @param {string} data
1169 */ 1169 */
1170 addEventSourceMessage(time, eventName, eventId, data) { 1170 addEventSourceMessage(time, eventName, eventId, data) {
1171 var message = {time: this.pseudoWallTime(time), eventName: eventName, eventI d: eventId, data: data}; 1171 var message = {time: this.pseudoWallTime(time), eventName: eventName, eventI d: eventId, data: data};
1172 this._eventSourceMessages.push(message); 1172 this._eventSourceMessages.push(message);
1173 this.dispatchEventToListeners(SDK.NetworkRequest.Events.EventSourceMessageAd ded, message); 1173 this.dispatchEventToListeners(SDK.NetworkRequest.Events.EventSourceMessageAd ded, message);
1174 } 1174 }
1175 1175
1176 replayXHR() { 1176 replayXHR() {
1177 this.target().networkAgent().replayXHR(this.requestId); 1177 this.target().networkAgent().replayXHR(this._requestId);
1178 } 1178 }
1179 1179
1180 /** 1180 /**
1181 * @return {!SDK.NetworkLog} 1181 * @return {!SDK.NetworkLog}
1182 */ 1182 */
1183 networkLog() { 1183 networkLog() {
1184 return this._networkLog; 1184 return this._networkLog;
1185 } 1185 }
1186 1186
1187 /** 1187 /**
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
1222 }; 1222 };
1223 1223
1224 /** @typedef {!{type: SDK.NetworkRequest.WebSocketFrameType, time: number, text: string, opCode: number, mask: boolean}} */ 1224 /** @typedef {!{type: SDK.NetworkRequest.WebSocketFrameType, time: number, text: string, opCode: number, mask: boolean}} */
1225 SDK.NetworkRequest.WebSocketFrame; 1225 SDK.NetworkRequest.WebSocketFrame;
1226 1226
1227 /** @typedef {!{time: number, eventName: string, eventId: string, data: string}} */ 1227 /** @typedef {!{time: number, eventName: string, eventId: string, data: string}} */
1228 SDK.NetworkRequest.EventSourceMessage; 1228 SDK.NetworkRequest.EventSourceMessage;
1229 1229
1230 /** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.Netw orkRequest>}} */ 1230 /** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.Netw orkRequest>}} */
1231 SDK.NetworkRequest.InitiatorGraph; 1231 SDK.NetworkRequest.InitiatorGraph;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698