Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/gcc_compile_wrapper.py

Issue 2617283002: Add Clang static analyzer to Clang toolchain defs in GN (Closed)
Patch Set: wez feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/clang_static_analyzer_wrapper.py ('k') | build/toolchain/gcc_toolchain.gni » ('j') | docs/clang_static_analyzer.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/gcc_compile_wrapper.py
diff --git a/build/toolchain/gcc_compile_wrapper.py b/build/toolchain/gcc_compile_wrapper.py
index 33cac37c7e51128f6c52a2739d923876f0262f7d..c56df3b432a35dc6931c30c159dc6e5d818e98d1 100755
--- a/build/toolchain/gcc_compile_wrapper.py
+++ b/build/toolchain/gcc_compile_wrapper.py
@@ -25,11 +25,10 @@ def main():
help='Compilation command')
args = parser.parse_args()
- returncode, stderr = wrapper_utils.CaptureCommandStderr(
+ returncode = wrapper_utils.RunCommand(
wrapper_utils.CommandToRun(args.command))
used_resources = wrapper_utils.ExtractResourceIdsFromPragmaWarnings(stderr)
Nico 2017/01/24 21:41:33 isn't this broken now? this needs stderr?
Kevin M 2017/01/24 21:46:18 Done.
- sys.stderr.write(stderr)
if args.resource_whitelist:
with open(args.resource_whitelist, 'w') as f:
« no previous file with comments | « build/toolchain/clang_static_analyzer_wrapper.py ('k') | build/toolchain/gcc_toolchain.gni » ('j') | docs/clang_static_analyzer.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698