Add Clang static analyzer to Clang toolchain defs in GN

build/toolchain/mac/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # TODO(brettw) Use "gcc_toolchain.gni" like the Linux toolchains. This requires
 # some enhancements since the commands on Mac are slightly different than on
 # Linux.
 
 import("../goma.gni")
 import("//build/config/clang/clang.gni")
 if (is_ios) {
   import("//build/config/ios/ios_sdk.gni")
 }
 import("//build/config/mac/mac_sdk.gni")
 import("//build/config/mac/symbols.gni")
 
 assert(host_os == "mac")
 
 import("//build/toolchain/cc_wrapper.gni")
 import("//build/toolchain/goma.gni")
 import("//build/toolchain/toolchain.gni")
 import("//build/toolchain/concurrent_links.gni")
 

[sdefresne, 2017/01/11 16:49:11]

You need to add import of //build/toolchain/clang_static_analyzer.gni here.

[Kevin M, 2017/01/11 18:27:46]

Done.

 declare_args() {
   # Reduce the number of tasks using the copy_bundle_data and compile_xcassets
   # tools as they can cause lots of I/O contention when invoking ninja with a
   # large number of parallel jobs (e.g. when using distributed build like goma).
   bundle_pool_depth = -1
 }
 
 if (current_toolchain == default_toolchain) {
   pool("bundle_pool") {
     if (bundle_pool_depth == -1) {
@@ skipping 81 matching lines @@
              "Goma and cc_wrapper can't be used together.")
       compiler_prefix = "$goma_dir/gomacc "
     } else if (toolchain_cc_wrapper != "") {
       compiler_prefix = toolchain_cc_wrapper + " "
     } else {
       compiler_prefix = ""
     }
 
     cc = compiler_prefix + _cc
     cxx = compiler_prefix + _cxx
-    ld = _cxx
+
+    if (use_clang_static_analyzer) {

[sdefresne, 2017/01/11 16:49:11]

I tried to run it with goma enabled and it got stuck. Maybe you want to assert
that toolchain_uses_goma == false here.

[Kevin M, 2017/01/11 18:27:46]

Done.

+      # Call "ccc-analyzer" or "c++-analyzer" instead of directly calling Clang.
+      # |wrapper_tool| sets the environment variables which are read by the
+      # analyzer tools.
+      analyzer_wrapper =
+          rebase_path("//build/toolchain/clang_static_analyzer_wrapper.py",
+                      root_build_dir)
+      cc = analyzer_wrapper + " --clang-cc-path=${cc} --analyzer=" + rebase_path(
+               "//third_party/llvm/tools/clang/tools/scan-build/libexec/ccc-analyzer",
+               root_build_dir)
+      cxx = analyzer_wrapper + " --clang-cxx-path=${cxx} --analyzer=" + rebase_path(
+                "//third_party/llvm/tools/clang/tools/scan-build/libexec/c++-analyzer",
+                root_build_dir)
+    }
+
+    ld = cxx
 
     linker_driver =
         "TOOL_VERSION=${tool_versions.linker_driver} " +
         rebase_path("//build/toolchain/mac/linker_driver.py", root_build_dir)
 
     # On iOS, the final applications are assembled using lipo (to support fat
     # builds). The correct flags are passed to the linker_driver.py script
     # directly during the lipo call.
     if (toolchain_args.current_os != "ios") {
       _enable_dsyms = enable_dsyms
@@ skipping 27 matching lines @@
       dsym_switch = ""
     }
 
     if (_save_unstripped_output) {
       _unstripped_output = "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.unstripped"
     }
 
     tool("cc") {
       depfile = "{{output}}.d"
       precompiled_header_type = "gcc"
-      command = "$env_wrapper $cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_c}} -c {{source}} -o {{output}}"

[sdefresne, 2017/01/11 16:49:11]

You need to restore "$env_wrapper" here otherwise the hermetic build will be
broken.

[Kevin M, 2017/01/11 18:27:46]

Done.

+      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_c}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "CC {{output}}"
       outputs = [
         "$object_subdir/{{source_name_part}}.o",
       ]
     }
 
     tool("cxx") {
       depfile = "{{output}}.d"
       precompiled_header_type = "gcc"
-      command = "$env_wrapper $cxx -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_cc}} -c {{source}} -o {{output}}"
+      command = "$cxx -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_cc}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "CXX {{output}}"
       outputs = [
         "$object_subdir/{{source_name_part}}.o",
       ]
     }
 
     tool("asm") {
       # For GCC we can just use the C compiler to compile assembly.
       depfile = "{{output}}.d"
-      command = "$env_wrapper $cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{asmflags}} -c {{source}} -o {{output}}"
+      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{asmflags}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "ASM {{output}}"
       outputs = [
         "$object_subdir/{{source_name_part}}.o",
       ]
     }
 
     tool("objc") {
       depfile = "{{output}}.d"
       precompiled_header_type = "gcc"
-      command = "$env_wrapper $cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_objc}} -c {{source}} -o {{output}}"
+      command = "$cc -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_objc}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "OBJC {{output}}"
       outputs = [
         "$object_subdir/{{source_name_part}}.o",
       ]
     }
 
     tool("objcxx") {
       depfile = "{{output}}.d"
       precompiled_header_type = "gcc"
-      command = "$env_wrapper $cxx -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_objcc}} -c {{source}} -o {{output}}"
+      command = "$cxx -MMD -MF $depfile {{defines}} {{include_dirs}} {{cflags}} {{cflags_objcc}} -c {{source}} -o {{output}}"
       depsformat = "gcc"
       description = "OBJCXX {{output}}"
       outputs = [
         "$object_subdir/{{source_name_part}}.o",
       ]
     }
 
     tool("alink") {
       script =
           rebase_path("//build/toolchain/mac/filter_libtool.py", root_build_dir)
@@ skipping 203 matching lines @@
   }
 }
 
 mac_toolchain("clang_x64") {
   toolchain_args = {
     current_cpu = "x64"
     current_os = "mac"
   }
 }
 
-mac_toolchain("clang_x86") {
-  toolchain_args = {
-    current_cpu = "x86"
-    current_os = "mac"
-  }
-}
-
-mac_toolchain("clang_x86_v8_arm") {
-  toolchain_args = {
-    current_cpu = "x86"
-    v8_current_cpu = "arm"
-    current_os = "mac"
-  }
-}
-
-mac_toolchain("clang_x86_v8_mipsel") {
-  toolchain_args = {
-    current_cpu = "x86"
-    v8_current_cpu = "mipsel"
-    current_os = "mac"
-  }
-}
-
-mac_toolchain("clang_x64_v8_arm64") {
-  toolchain_args = {
-    current_cpu = "x64"
-    v8_current_cpu = "arm64"
-    current_os = "mac"
-  }
-}
-
-mac_toolchain("clang_x64_v8_mips64el") {
-  toolchain_args = {
-    current_cpu = "x64"
-    v8_current_cpu = "mips64el"
-    current_os = "mac"
-  }
-}
-
 if (is_ios) {
   mac_toolchain("ios_clang_arm") {
     toolchain_args = {
       current_cpu = "arm"
       current_os = "ios"
     }
   }
 
   mac_toolchain("ios_clang_arm64") {
     toolchain_args = {
       current_cpu = "arm64"
       current_os = "ios"
     }
   }
 
   mac_toolchain("ios_clang_x86") {
     toolchain_args = {
       current_cpu = "x86"
       current_os = "ios"
     }
   }
 
   mac_toolchain("ios_clang_x64") {
     toolchain_args = {
       current_cpu = "x64"
       current_os = "ios"
     }
   }
 }