[Predator] Move ``SingleFeatureScore`` to LLM.

appengine/findit/crash/loglinear/test/changelist_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 import math
 import pprint
 
 from common.dependency import Dependency
 from common.dependency import DependencyRoll
 from common.chrome_dependency_fetcher import ChromeDependencyFetcher
 import crash.changelist_classifier as scorer_changelist_classifier
 from crash.crash_report import CrashReport
 from crash.loglinear.changelist_classifier import LogLinearChangelistClassifier
-from crash.loglinear.feature import ChangedFile
-from crash.loglinear.feature import FeatureValue
 from crash.suspect import AnalysisInfo
 from crash.suspect import Suspect
 from crash.suspect import StackInfo
 from crash.stacktrace import CallStack
 from crash.stacktrace import StackFrame
 from crash.stacktrace import Stacktrace
 from crash.test.crash_test_suite import CrashTestSuite
 from crash.type_enums import CallStackFormatType
 from crash.type_enums import LanguageType
 from libs.gitiles.change_log import ChangeLog
@@ skipping 83 matching lines @@
   def setUp(self):
     super(LogLinearChangelistClassifierTest, self).setUp()
     weights = {
         'MinDistance': 1.,
         'TopFrameIndex': 1.,
     }
 
     self.changelist_classifier = LogLinearChangelistClassifier(
         GitilesRepository.Factory(self.GetMockHttpClient()), weights)
 
-  def testAggregateChangedFilesAggregates(self):
-    """Test that ``AggregateChangedFiles`` does aggregate reasons per file.
-
-    In the main/inner loop of ``AggregateChangedFiles``: if multiple
-    features all blame the same file change, we try to aggregate those
-    reasons so that we only report the file once (with all reasons). None
-    of the other tests here actually check the case where the same file
-    is blamed multiple times, so we check that here.
-
-    In particular, we provide the same ``FeatureValue`` twice, and
-    hence the same ``ChangedFile`` twice; so we should get back a single
-    ``ChangedFile`` but with the ``reasons`` fields concatenated.
-    """
-    file_reason = 'I blame you!'
-    file_blame = ChangedFile(
-        name = 'a.cc',
-        blame_url = None,
-        reasons = [file_reason]
-    )
-
-    feature_value = FeatureValue(
-        name = 'dummy feature',
-        value = 42,
-        reason = 'dummy reason',
-        changed_files = [file_blame]
-    )
-
-    expected_file_blame = file_blame._replace(reasons = [file_reason] * 2)
-
-    self.assertListEqual(
-        [expected_file_blame],
-        self.changelist_classifier.AggregateChangedFiles(
-            [feature_value] * 2))
-
   # TODO(http://crbug.com/659346): why do these mocks give coverage
   # failures? That's almost surely hiding a bug in the tests themselves.
   def testFindItForCrashNoRegressionRange(self): # pragma: no cover
     self.mock(ChromeDependencyFetcher, 'GetDependencyRollsDict', lambda *_: {})
     self.mock(ChromeDependencyFetcher, 'GetDependency', lambda *_: {})
     # N.B., for this one test we really do want regression_range=None.
     report = DUMMY_REPORT._replace(regression_range=None)
     self.assertListEqual(self.changelist_classifier(report), [])
 
   def testFindItForCrashNoMatchFound(self):
@@ skipping 188 matching lines @@
           'f.cc': AnalysisInfo(min_distance=20, min_distance_frame=frame3)
       }
 
       return [suspect1, suspect2]
 
     self.mock(scorer_changelist_classifier, 'FindSuspects', _MockFindSuspects)
 
     suspects = self.changelist_classifier(DUMMY_REPORT)
     self.assertFalse(suspects, 'Expected zero suspects, but found some:\n%s'
         % pprint.pformat([suspect.ToDict() for suspect in suspects]))