third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html - Issue 2617183002: Add more WebVR layout tests, adjust test format

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html

Issue 2617183002: Add more WebVR layout tests, adjust test format (Closed)

Patch Set: Add some missing catches for failed getVRDisplays Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/vr/getLayers_presenting.html ('K') | « third_party/WebKit/LayoutTests/vr/getLayers_presenting.html ('k') | third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html » ('j') | third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script src="../resources/mojo-helpers.js"></script>	4 <script src="../resources/mojo-helpers.js"></script>

5 <script src="resources/fake-vr-displays.js"></script>	5 <script src="resources/fake-vr-displays.js"></script>

6 <script src="resources/mock-vr-service.js"></script>	6 <script src="resources/mock-vr-service.js"></script>

7 <script>	7 <script>

8 let fakeDisplays = fakeVRDisplays();	8 let fakeDisplays = fakeVRDisplays();

9	9

10 vr_test((service) => {	10 vr_test( (t) => {

11 return navigator.getVRDisplays().then(devices => {	11 return navigator.getVRDisplays().then( (displays) => {

12 assert_true(devices != null);	12 t.step( () => {

13 assert_equals(1, devices.length);	13 assert_true(displays != null);

14 assert_equals(devices[0].displayName, 'Google, Inc. Daydream View');	14 assert_equals(1, displays.length);

15 assert_true(devices[0].capabilities.hasOrientation);	15 let display = displays[0];

16 assert_true(devices != null);	16 assert_equals(display.displayName, 'Google, Inc. Daydream View');

	17 assert_true(display.capabilities.hasOrientation);

	18 assert_equals(display.depthNear, 0.01);
	bajones 2017/01/06 20:20:25 Again, let's try to consistently use approx_equals Again, let's try to consistently use approx_equals for floats. bsheedy 2017/01/06 22:14:19 Done. Show quoted text On 2017/01/06 20:20:25, bajones wrote: > Again, let's try to consistently use approx_equals for floats. Done.
	19 assert_equals(display.depthFar, 10000.0);

	20 }, "getVRDisplays returned correct results");

	21 }, (err) => {

	22 t.step( () => {

	23 assert_unreached("getVRDisplays rejected");

17 });	24 });

18 }, [fakeDisplays['Pixel']], 'test 1 VRDisplay');	25 }).then( () => {

	26 t.done();

	27 });

	28 }, [fakeDisplays["Pixel"]],

	29 "WebVR properly returns a single display");

19	30

20 </script>	31 </script>

OLD	NEW