Chromium Code Reviews Chromium Code Reviews
Issue 2617183002:
Add more WebVR layout tests, adjust test format (Closed)
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <script src="../resources/testharness.js"></script> | |
| 3 <script src="../resources/testharnessreport.js"></script> | |
| 4 <script src="../resources/mojo-helpers.js"></script> | |
| 5 <script src="resources/fake-vr-displays.js"></script> | |
| 6 <script src="resources/mock-vr-service.js"></script> | |
| 7 <canvas id="webgl-canvas"></canvas> | |
| 8 <script src="resources/presentation-setup.js"></script> | |
| 9 <script> | |
| 10 let fakeDisplays = fakeVRDisplays(); | |
| 11 | |
| 12 vr_test( (t) => { | |
| 13 return navigator.getVRDisplays().then( (displays) => { | |
| 14 t.step( () => { | |
| 15 assert_true(displays != null); | |
| 16 assert_equals(1, displays.length); | |
|
bajones
2017/01/06 20:20:25
For consistency let's make sure the assert's argum
bsheedy
2017/01/06 22:14:19
Done.
| |
| 17 }, "getVRDisplays returned correct results"); | |
|
bajones
2017/01/06 20:20:25
Seems redundant to have this check in every single
bsheedy
2017/01/06 22:14:19
Done, removed from tests except for ones specifica
| |
| 18 var display = displays[0]; | |
| 19 | |
| 20 t.step( () => { | |
| 21 assert_equals(display.getLayers().length, 0); | |
| 22 }, "No layers initially returned"); | |
| 23 | |
| 24 runWithUserGesture( () => { | |
| 25 display.requestPresent([{ source : webglCanvas }]).then( () => { | |
| 26 t.step( () => { | |
| 27 let layers = display.getLayers(); | |
| 28 assert_equals(layers.length, 1); | |
| 29 let layer = layers[0]; | |
| 30 | |
| 31 assert_equals(layer.source, webglCanvas); | |
|
bajones
2017/01/06 20:20:25
For consistency let's swap the order of these thre
bsheedy
2017/01/06 22:14:18
If we want assert_equals(actual, expected), then t
| |
| 32 assert_equals(layer.leftBounds.length, 4); | |
| 33 assert_equals(layer.rightBounds.length, 4); | |
| 34 | |
| 35 let expectedLeft = [0.0, 0.0, 0.5, 1.0]; | |
| 36 let expectedRight = [0.5, 0.0, 0.5, 1.0]; | |
| 37 for (let i = 0; i < layer.leftBounds.length; i++) { | |
| 38 assert_equals(layer.leftBounds[i], expectedLeft[i]); | |
| 39 assert_equals(layer.rightBounds[i], expectedRight[i]); | |
| 40 } | |
| 41 }, "Layer is correct"); | |
| 42 }, (err) => { | |
| 43 t.step( () => { | |
| 44 assert_unreached(); | |
| 45 }, "requestPresent failed"); | |
| 46 }).then( () => { | |
| 47 t.done(); | |
| 48 }); | |
| 49 }); | |
| 50 }, (err) => { | |
| 51 t.step( () => { | |
| 52 assert_unreached(); | |
| 53 }, "getVRDisplays rejected"); | |
| 54 t.done(); | |
| 55 }); | |
| 56 }, [fakeDisplays["Pixel"]], | |
| 57 "Test getLayers returns an empty array when not presenting"); | |
| 58 | |
| 59 </script> | |
| OLD | NEW |
