Issue 2617163002: Revert "reflectType() dynamic type arguments support (#26012)"

Issue 2617163002: Revert "reflectType() dynamic type arguments support (#26012)" (Closed)

Created:
3 years, 11 months ago by asgerf

Modified:
3 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "reflectType() dynamic type arguments support (#26012)" This reverts commit 8a8033a4176a2f26e8ed035497631d539dc1ede5. There are a bunch of dart2js mirror tests that fail. Issue https://github.com/dart-lang/sdk/pull/26012 BUG= Committed: https://github.com/dart-lang/sdk/commit/6bae3151e25eb743814275f8d03b3b61de925a8d

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+461 lines, -643 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 chunk	+0 lines, -64 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	runtime/lib/mirrors_patch.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_mirrors.dart	View	80 chunks	+428 lines, -422 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/mirrors_patch.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	11 chunks	+28 lines, -33 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	tests/lib/mirrors/reflected_type_generics_test.dart	View	1 chunk	+0 lines, -99 lines	0 comments	Download
M	tests/lib/mirrors/reflected_type_helper.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

asgerf

Committed patchset #1 (id:1) manually as 6bae3151e25eb743814275f8d03b3b61de925a8d (presubmit successful).

3 years, 11 months ago (2017-01-06 18:12:34 UTC) #4

floitsch

On 2017/01/06 18:12:34, asgerf wrote: > Committed patchset #1 (id:1) manually as > 6bae3151e25eb743814275f8d03b3b61de925a8d (presubmit ...

3 years, 11 months ago (2017-01-06 18:52:03 UTC) #5

Message was sent while issue was closed.

and LGTM.