Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java

Issue 2617133002: [Android NTP] Move more of the dismissal logic into the tree. (Closed)
Patch Set: annotation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
index ace1a3221a3cd93bc5678d50833498e277a64fd5..fc1be75a77c34a84d31f367ca1655b0b6135e0a5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
@@ -13,15 +13,12 @@ import android.widget.TextView;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.ContextMenuManager;
-import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
-import org.chromium.chrome.browser.ntp.ContextMenuManager.Delegate;
import org.chromium.chrome.browser.ntp.UiConfig;
-import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
/**
* ViewHolder for Status and Promo cards.
*/
-public class StatusCardViewHolder extends CardViewHolder implements ContextMenuManager.Delegate {
+public class StatusCardViewHolder extends CardViewHolder {
private final TextView mTitleView;
private final TextView mBodyView;
private final Button mActionView;
@@ -85,37 +82,4 @@ public class StatusCardViewHolder extends CardViewHolder implements ContextMenuM
mActionView.setVisibility(View.GONE);
}
}
-
- @Override
- protected Delegate getContextMenuDelegate() {
- return this;
- }
-
- @Override
- public void openItem(int windowDisposition) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void removeItem() {
- getRecyclerView().dismissItemWithAnimation(this);
- }
-
- @Override
- public String getUrl() {
- return null;
- }
-
- @Override
- public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
- return menuItemId == ContextMenuManager.ID_REMOVE && isDismissable();
- }
-
- @Override
- public void onContextMenuCreated() {}
-
- @Override
- public boolean isDismissable() {
- return SnippetsConfig.isSectionDismissalEnabled();
- }
}

Powered by Google App Engine
This is Rietveld 408576698