Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2617133002: [Android NTP] Move more of the dismissal logic into the tree. (Closed)
Patch Set: annotation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
index 786f126a4227239acb9a414cdb32c332b903a2c0..08aa3ba316ad958592bcf85aa33efae8d43c6835 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
@@ -10,11 +10,8 @@ import android.view.View;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ntp.ContextMenuManager;
-import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
-import org.chromium.chrome.browser.ntp.ContextMenuManager.Delegate;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
-import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.suggestions.SuggestionsRanker;
import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
@@ -139,40 +136,6 @@ public class ActionItem extends OptionalLeaf {
});
}
- @Override
- public boolean isDismissable() {
- return SnippetsConfig.isSectionDismissalEnabled()
- && !mActionListItem.mParentSection.hasSuggestions();
- }
-
- @Override
- protected Delegate getContextMenuDelegate() {
- return this;
- }
-
- @Override
- public void openItem(int windowDisposition) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void removeItem() {
- getRecyclerView().dismissItemWithAnimation(this);
- }
-
- @Override
- public String getUrl() {
- return null;
- }
-
- @Override
- public boolean isItemSupported(@ContextMenuItemId int menuItemId) {
- return menuItemId == ContextMenuManager.ID_REMOVE && isDismissable();
- }
-
- @Override
- public void onContextMenuCreated() {}
-
public void onBindViewHolder(ActionItem item) {
super.onBindViewHolder();
mActionListItem = item;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698