Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 261713003: Don't consider shutdown acknowledgement for external extensions (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Don't consider shutdown acknowledgement for external extensions External extensions display a warning, and, on shutdown, we close that warning and treat it as an "abort". This has the effect of uninstalling the extension - this is bad, because a) the user won't expect it, and b) we're in the process of shutting down and shouldn't be doing something like uninstalling. Only treat an abort as an uninstall if it's user initiated. BUG=370222 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/extensions/external_install_ui.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
6 years, 7 months ago (2014-05-06 15:57:16 UTC) #1
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-05-06 17:55:11 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-07 15:49:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/261713003/1
6 years, 7 months ago (2014-05-07 15:52:33 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 21:09:49 UTC) #5
Message was sent while issue was closed.
Change committed as 268947

Powered by Google App Engine
This is Rietveld 408576698