Issue 2616993002: Reject patches that change parameter names/types or return types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2616993002: Reject patches that change parameter names/types or return types. (Closed)

Created:
3 years, 11 months ago by Paul Berry

Modified:
3 years, 11 months ago

Reviewers:
scheglov, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+483 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/dart/sdk/patch.dart	View		5 chunks	+103 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/sdk/patch_test.dart	View		4 chunks	+380 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

Kevin, this implements the check you requested (parameter names match) as well as a bunch ...

3 years, 11 months ago (2017-01-05 19:10:40 UTC) #2

Paul Berry

3 years, 11 months ago (2017-01-06 17:01:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d061d393426bf5d5c5db1984de7a3ef71245ea80 (presubmit successful).