Ensure we're looking at the correct resolved AST when initializing fields in constructors.

Ensure we're looking at the correct resolved AST when initializing fields in constructors.

Step 30 of bagilliondy.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c78abd0900d10198216034f296204f4de1c111e

[Emily Fortuna, 2017-01-05 22:59:18]

efortuna@google.com changed reviewers:
+ sigmund@google.com

[Emily Fortuna, 2017-01-05 22:59:19]

After all that effort to write a test, we still need to implement some other
constructor details before the kernel tests can run O.O I wrote a test, but it's
not enabled yet.

[Siggi Cherem (dart-lang), 2017-01-05 23:23:31]

lgtm

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolved_uri_translator.dart (right):

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolved_uri_translator.dart:118:
importingLibrary.canonicalUri.scheme == 'memory' ||
let's add a comment that this is for unit tests that use the in-memory compiler

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:52: /// constructing the field
values). We keep track of this with a stack.
constructing => initializing

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:53: Queue<ResolvedAst>
_resolvedAstStack;
side comment: We have a tendency in dart2js to use Link<> (from
lib/src/util/link.dart) instead of Queue<> or List<>. That might have been
historical, and in this specific use case I'm guessing it doesn't matter, so I'm
OK keeping it as it is. I'll double check to see if there are any reasons to
continue using Link in this case.

[Emily Fortuna, 2017-01-06 00:19:25]

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolved_uri_translator.dart (right):

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolved_uri_translator.dart:118:
importingLibrary.canonicalUri.scheme == 'memory' ||
On 2017/01/05 23:23:31, Siggi Cherem (dart-lang) wrote:
> let's add a comment that this is for unit tests that use the in-memory
compiler

Done.

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:52: /// constructing the field
values). We keep track of this with a stack.
On 2017/01/05 23:23:31, Siggi Cherem (dart-lang) wrote:
> constructing => initializing

oops yes

https://codereview.chromium.org/2616933003/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:53: Queue<ResolvedAst>
_resolvedAstStack;
On 2017/01/05 23:23:31, Siggi Cherem (dart-lang) wrote:
> side comment: We have a tendency in dart2js to use Link<> (from
> lib/src/util/link.dart) instead of Queue<> or List<>. That might have been
> historical, and in this specific use case I'm guessing it doesn't matter, so
I'm
> OK keeping it as it is. I'll double check to see if there are any reasons to
> continue using Link in this case.

Acknowledged.

[Emily Fortuna, 2017-01-06 00:20:02]

Description was changed from

==========
Ensure we're looking at the correct resolved AST when initializing fields in
constructors.

Step 30 of bagilliondy.

BUG=https://github.com/dart-lang/sdk/issues/27394
==========

to

==========
Ensure we're looking at the correct resolved AST when initializing fields in
constructors.

Step 30 of bagilliondy.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0c78abd0900d10198216034f296204f4de1c111e
==========

[Emily Fortuna, 2017-01-06 00:20:03]

Committed patchset #4 (id:60001) manually as
0c78abd0900d10198216034f296204f4de1c111e (presubmit successful).

[sra1, 2017-01-06 00:39:25]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-01-06 00:39:26]

DBC

https://codereview.chromium.org/2616933003/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2616933003/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:53: Queue<ResolvedAst>
_resolvedAstStack;
You could simply use

  final List<ResolvedAst> _resolvedAstStack = <ResolvedAst>[];


growable lists support stacks via add() and removeLast().