Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm

Issue 2616843002: Remove deprecated wait_util methods. (Closed)
Patch Set: Convert remaining uses of WaitUntilCondition. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/omnibox_perftest.mm ('k') | ios/web/public/test/web_test_with_web_state.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
diff --git a/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm b/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
index 5b93233d0734e7820b73aae5d2de9a1d9c5dd27b..cb5dbcef6dc0295bcf8a80b4facf9bf8e313b4fe 100644
--- a/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
+++ b/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
@@ -257,9 +257,9 @@ void StackViewControllerPerfTest::WaitForPageLoad(Tab* tab) {
^bool() {
return !tab.webState->IsLoading();
},
- nullptr, base::TimeDelta::FromSecondsD(kMaxPageLoadDelay));
+ false, base::TimeDelta::FromSecondsD(kMaxPageLoadDelay));
base::test::ios::WaitUntilCondition(
- nil, nullptr, base::TimeDelta::FromSecondsD(kMaxUICatchupDelay));
+ nil, false, base::TimeDelta::FromSecondsD(kMaxUICatchupDelay));
}
base::TimeDelta StackViewControllerPerfTest::OpenStackView() {
@@ -271,7 +271,7 @@ base::TimeDelta StackViewControllerPerfTest::OpenStackView() {
^bool() {
return [delegate_ showAnimationEnded];
},
- nullptr, base::TimeDelta::FromSecondsD(kTotalSpinDelay));
+ false, base::TimeDelta::FromSecondsD(kTotalSpinDelay));
}
void StackViewControllerPerfTest::MainControllerShowTabSwitcher() {
@@ -326,7 +326,7 @@ base::TimeDelta StackViewControllerPerfTest::CloseStackView() {
^bool() {
return [delegate_ dismissAnimationEnded];
},
- nullptr, base::TimeDelta::FromSecondsD(kTotalSpinDelay));
+ false, base::TimeDelta::FromSecondsD(kTotalSpinDelay));
[view_controller_ dismissViewControllerAnimated:NO completion:nil];
if (!reuse_svc_)
@@ -338,7 +338,7 @@ base::TimeDelta StackViewControllerPerfTest::CloseStackView() {
// in the OS during view teardown to resolve, so that the view gets its
// dismissal callbacks.
base::test::ios::WaitUntilCondition(
- nil, nullptr, base::TimeDelta::FromSecondsD(kSpinDelay));
+ nil, false, base::TimeDelta::FromSecondsD(kSpinDelay));
return closeTime;
}
« no previous file with comments | « ios/chrome/browser/ui/omnibox_perftest.mm ('k') | ios/web/public/test/web_test_with_web_state.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698