Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 261683005: Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
Reviewers:
michaeln, ericu, piman
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (https://codereview.chromium.org/259773006/) Reason for revert: I'm sorry to revert this change. It looks like it breaks the ASAN bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2161/steps/content_unittests/logs/ResolveBlobAndCreateUploadDataStream Direct leak of 120 byte(s) in 3 object(s) allocated from: #0 0x520dbb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x3a0f611 in webkit_blob::BlobDataHandle::BlobDataHandle(webkit_blob::BlobData*, webkit_blob::BlobStorageContext*, base::SequencedTaskRunner*) webkit/browser/blob/blob_data_handle.cc:42 #2 0x3a0fd71 in webkit_blob::BlobStorageContext::GetBlobDataFromUUID(std::string const&) webkit/browser/blob/blob_storage_context.cc:69 #3 0x268955d in ResolveBlobReference content/browser/loader/upload_data_stream_builder.cc:73 ... Original issue's description: > Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. > > BUG=108012 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266817 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267423 TBR=michaeln@chromium.org,piman@chromium.org,ericu@chromium.org NOTREECHECKS=true NOTRY=true BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -101 lines) Patch
M content/browser/fileapi/blob_storage_context_unittest.cc View 7 chunks +0 lines, -27 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.h View 1 chunk +8 lines, -27 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.cc View 1 chunk +27 lines, -39 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
Created Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any ...
6 years, 7 months ago (2014-05-01 07:57:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/261683005/1
6 years, 7 months ago (2014-05-01 07:57:22 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 08:03:28 UTC) #3
Message was sent while issue was closed.
Change committed as 267479

Powered by Google App Engine
This is Rietveld 408576698