Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: src/trusted/desc/nacl_desc_wrapper.cc

Issue 261683002: Make a NaClDesc ctor for creating descs from NaClFileInfo. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: use or Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/desc/nacl_desc_wrapper.h ('k') | src/trusted/desc_cacheability/desc_cacheability.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/desc/nacl_desc_wrapper.cc
diff --git a/src/trusted/desc/nacl_desc_wrapper.cc b/src/trusted/desc/nacl_desc_wrapper.cc
index ada9cb3aad152810f52670b829e4925ed1652c11..5d7013561809c98302172f25ce3a687abd72645b 100644
--- a/src/trusted/desc/nacl_desc_wrapper.cc
+++ b/src/trusted/desc/nacl_desc_wrapper.cc
@@ -315,6 +315,27 @@ DescWrapper* DescWrapperFactory::MakeFileDesc(int host_os_desc, int mode) {
return MakeGenericCleanup(desc);
}
+DescWrapper* DescWrapperFactory::MakeFileDescMetadata(struct NaClFileInfo info,
+ int mode) {
+ int error;
+ struct NaClDesc* desc = ImportHostDescCommon(info.desc, mode);
+ if (NULL == desc) {
+ return NULL;
+ }
+ if (info.file_token.lo != 0 || info.file_token.hi != 0) {
Nick Bray (chromium) 2014/05/02 19:44:35 See previous CLs for comments on this check.
jvoung (off chromium) 2014/05/02 20:38:23 Done.
+ error = (*NACL_VTBL(NaClDesc, desc)->
Nick Bray (chromium) 2014/05/02 19:44:35 Why no NaClDescSetFileToken?
jvoung (off chromium) 2014/05/02 20:38:23 That's part of desc_cacheabiilty/ and desc_cacheab
+ SetMetadata)(desc,
+ NACL_DESC_METADATA_FILE_TOKEN_TYPE,
+ sizeof info.file_token,
+ (uint8_t const *) &info.file_token);
+ if (0 != error) {
+ NaClDescSafeUnref(desc);
+ return NULL;
+ }
+ }
+ return MakeGenericCleanup(desc);
+}
+
DescWrapper* DescWrapperFactory::MakeFileDescQuota(int host_os_desc,
int mode,
const uint8_t* file_id) {
« no previous file with comments | « src/trusted/desc/nacl_desc_wrapper.h ('k') | src/trusted/desc_cacheability/desc_cacheability.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698