Source/core/rendering/HitTestResult.cpp - Issue 26168008: [blink] Avoid null pointer dereference in HitTestResult::isMisspelled()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 26168008: [blink] Avoid null pointer dereference in HitTestResult::isMisspelled() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Original fix Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/HitTestResult.cpp

diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp

index 27c2671e1ea2134ff0381ae7fea5018a69325b08..b80a9a02048b4c4bd77b0e1c3c4a606822549f01 100644

--- a/Source/core/rendering/HitTestResult.cpp

+++ b/Source/core/rendering/HitTestResult.cpp

@@ -347,7 +347,7 @@ bool HitTestResult::isLiveLink() const

bool HitTestResult::isMisspelled() const

{

- if (!targetNode())

+ if (!targetNode() || !targetNode()->renderer())

return false;

VisiblePosition pos(targetNode()->renderer()->positionForPoint(localPoint()));

if (pos.isNull())

« no previous file with comments | « LayoutTests/editing/spelling/right-click-no-renderer-crash-expected.txt ('k') | no next file » | no next file with comments »