LayoutTests/editing/spelling/right-click-no-renderer-crash.html - Issue 26168008: [blink] Avoid null pointer dereference in HitTestResult::isMisspelled()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/spelling/right-click-no-renderer-crash.html

Issue 26168008: [blink] Avoid null pointer dereference in HitTestResult::isMisspelled() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add expectations. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <script>

	6 window.onload = function() {

	7 var element = document.getElementsByTagName('*')[0];
	eseidel 2014/02/25 00:30:02 Can we be more specific as to which element we're Can we be more specific as to which element we're selecting? Presumably the <script> element? please use gerrit instead 2014/02/25 01:14:53 Changed '' to 'html'. Only <html> element causes Show quoted text On 2014/02/25 00:30:02, eseidel wrote: > Can we be more specific as to which element we're selecting? Presumably the > <script> element? Changed '' to 'html'. Only <html> element causes the crash with these steps to reproduce the bug.
	8 document.adoptNode(element);

	9 var newElement = document.createElementNS('http://www.w3.org/2000/svg', 'title ');

	10 document.appendChild(newElement);

	11 document.execCommand('SelectAll', false)

	12 document.designMode = 'on';

	13

	14 description('Page should not crash when a node does not have a renderer object associated with it. ' +

	15 'To test manually, right-click anywhere on the page. ' +

	16 'The test succeeds if the page does not crash. ');

	17

	18 if (window.eventSender) {

	19 eventSender.contextClick();
	eseidel 2014/02/25 00:30:02 Is this click at 0,0? Is this click at 0,0? please use gerrit instead 2014/02/25 01:14:53 Changed the click to be explicitly at (10, 10). It Show quoted text On 2014/02/25 00:30:02, eseidel wrote: > Is this click at 0,0? Changed the click to be explicitly at (10, 10). It was (0, 0) originally, but I don't want to make assumptions on whether (0, 0) is inside or outside the page on different platforms.
	20 }

	21

	22 finishJSTest();

	23 };

	24 </script>

	25 </head>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/spelling/right-click-no-renderer-crash-expected.txt » ('j') | Source/core/rendering/HitTestResult.cpp » ('J')