Remove Print As Image for Mac and Win

chrome/test/data/webui/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN('#include "base/feature_list.h"');
 GEN('#include "chrome/common/chrome_features.h"');
 
 /**
  * Test fixture for print preview WebUI testing.
  * @constructor
@@ skipping 49 matching lines @@
   /**
    * @override
    */
   testGenPreamble: function() {
     // Enable print scaling and print as image for tests.
     GEN('  base::FeatureList::ClearInstanceForTesting();');
     GEN('  std::unique_ptr<base::FeatureList>');
     GEN('      feature_list(new base::FeatureList);');
     GEN('  char enabled_features[128] = {0};');
     GEN('  strcpy(enabled_features, features::kPrintScaling.name);');
+    GEN('#if defined(OS_CHROMEOS) || defined(OS_LINUX)');

[dpapad, 2017/01/06 17:09:40]

This needs to be changed too, right?

[rbpotter, 2017/01/06 19:32:34]

Done.

     GEN('  strcat(strcat(enabled_features, ","), ');
     GEN('      features::kPrintPdfAsImage.name);');
+    GEN('#endif');
     GEN('  feature_list->InitializeFromCommandLine(');
     GEN('      enabled_features, std::string());');
     GEN('  base::FeatureList::SetInstance(std::move(feature_list));');
   },
 
   /**
    * Stub out low-level functionality like the NativeLayer and
    * CloudPrintInterface.
    * @this {PrintPreviewWebUITest}
    * @override
@@ skipping 434 matching lines @@
               is_default: true
             }
           ]
         }
       }
     }
   };
   this.setCapabilities(device);
 
   var otherOptions = $('other-options-settings');
-  checkSectionVisible(otherOptions, true);
-  checkElementDisplayed(
-      otherOptions.querySelector('#fit-to-page-container'), false);
-  checkElementDisplayed(
-      otherOptions.querySelector('#rasterize-container'), true);
+  // If rasterization is an option, other options should be visible. If not,
+  // there should be no available other options.
+  checkSectionVisible(otherOptions, !cr.isWindows && !cr.isMac);
+  if (!cr.isWindows && !cr.isMac) {
+    checkElementDisplayed(
+        otherOptions.querySelector('#fit-to-page-container'), false);
+    checkElementDisplayed(
+        otherOptions.querySelector('#rasterize-container'), true);
+  }
   checkSectionVisible($('media-size-settings'), false);
   checkSectionVisible($('scaling-settings'), false);
 
   testDone();
 });
 
 // When the source is 'HTML', we always hide the fit to page option and show
 // media size option.
 TEST_F('PrintPreviewWebUITest', 'SourceIsHTMLCapabilities', function() {
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   var fitToPage = otherOptions.querySelector('#fit-to-page-container');
-  var rasterize = otherOptions.querySelector('#rasterize-container');
+  var rasterize;
+  var rasterizeEnabled = !cr.isWindows && !cr.isMac;

[dpapad, 2017/01/06 17:09:40]

Can this be moved in the constructor of PrintPreviewWebUITest (lines 13-17)? Or
is cr.isWindows and cr.isMac not defined yet at that point?

[rbpotter, 2017/01/06 19:32:34]

cr is not defined at that point.

+  if (rasterizeEnabled)
+    rasterize = otherOptions.querySelector('#rasterize-container');
   var mediaSize = $('media-size-settings');
   var scalingSettings = $('scaling-settings');
 
   // Check that options are collapsed (section is visible, because duplex is
   // available).
   checkSectionVisible(otherOptions, true);
   checkElementDisplayed(fitToPage, false);
-  checkElementDisplayed(rasterize, false);
+  if (rasterizeEnabled)
+    checkElementDisplayed(rasterize, false);
   checkSectionVisible(mediaSize, false);
   checkSectionVisible(scalingSettings, false);
 
   this.expandMoreSettings();
 
   checkElementDisplayed(fitToPage, false);
-  checkElementDisplayed(rasterize, false);
+  if (rasterizeEnabled)
+    checkElementDisplayed(rasterize, false);
   checkSectionVisible(mediaSize, true);
   checkSectionVisible(scalingSettings, true);
 
   this.waitForAnimationToEnd('more-settings');
 });
 
 // When the source is "PDF", depending on the selected destination printer, we
 // show/hide the fit to page option and hide media size selection.
 TEST_F('PrintPreviewWebUITest', 'SourceIsPDFCapabilities', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   var scalingSettings = $('scaling-settings');
   var fitToPageContainer =
       otherOptions.querySelector('#fit-to-page-container');
-  var rasterizeContainer =
+  var rasterizeEnabled = !cr.isWindows && !cr.isMac;
+  var rasterizeContainer;
+  if (rasterizeEnabled) {
+    rasterizeContainer =
       otherOptions.querySelector('#rasterize-container');
+  }
 
   checkSectionVisible(otherOptions, true);
   checkElementDisplayed(fitToPageContainer, true);
-  checkElementDisplayed(rasterizeContainer, false);
+  if (rasterizeEnabled)
+    checkElementDisplayed(rasterizeContainer, false);
   expectTrue(
       fitToPageContainer.querySelector('.checkbox').checked);
   this.expandMoreSettings();
-  checkElementDisplayed(rasterizeContainer, true);
-  expectFalse(
-      rasterizeContainer.querySelector('.checkbox').checked);
+  if (rasterizeEnabled) {
+    checkElementDisplayed(rasterizeContainer, true);
+    expectFalse(
+        rasterizeContainer.querySelector('.checkbox').checked);
+  }
   checkSectionVisible($('media-size-settings'), true);
   checkSectionVisible(scalingSettings, true);
 
   this.waitForAnimationToEnd('other-options-collapsible');
 });
 
 // When the source is "PDF", depending on the selected destination printer, we
 // show/hide the fit to page option and hide media size selection.
 TEST_F('PrintPreviewWebUITest', 'ScalingUnchecksFitToPage', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
@@ skipping 626 matching lines @@
   // appears.
   var advancedSettingsCloseButton = $('advanced-settings').
       querySelector('.close-button');
   checkElementDisplayed(advancedSettingsCloseButton, true);
   checkElementDisplayed($('advanced-settings').
       querySelector('.search-box-area'), true);
 
   this.waitForAnimationToEnd('more-settings');
 });