Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 261673004: eliminate mac xcode 5 only warning (Closed)

Created:
6 years, 7 months ago by caryclark
Modified:
6 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

eliminate mac xcode 5 only warning on os x 10.9.2 unistd.h defines sysconf as long sysconf(int); Committed: http://code.google.com/p/skia/source/detail?r=14559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/utils/SkThreadPool.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
caryclark
6 years, 7 months ago (2014-04-30 20:30:15 UTC) #1
mtklein
lgtm
6 years, 7 months ago (2014-04-30 20:40:56 UTC) #2
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-04-30 20:44:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/261673004/1
6 years, 7 months ago (2014-04-30 20:44:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 20:45:02 UTC) #5
commit-bot: I haz the power
Presubmit check for 261673004-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 7 months ago (2014-04-30 20:45:02 UTC) #6
caryclark
6 years, 7 months ago (2014-04-30 20:45:56 UTC) #7
caryclark
6 years, 7 months ago (2014-05-01 16:21:40 UTC) #8
reed1
lgtm
6 years, 7 months ago (2014-05-01 16:22:10 UTC) #9
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-05-01 16:22:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/261673004/1
6 years, 7 months ago (2014-05-01 16:22:39 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 19:16:09 UTC) #12
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Nexus7-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 7 months ago (2014-05-01 19:16:10 UTC) #13
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-05-04 00:46:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/261673004/1
6 years, 7 months ago (2014-05-04 00:46:41 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-04 00:46:52 UTC) #16
Message was sent while issue was closed.
Change committed as 14559

Powered by Google App Engine
This is Rietveld 408576698