Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: gpu/command_buffer/tests/gl_dynamic_config_unittest.cc

Issue 2616723002: Refactor GL surface format handling (Closed)
Patch Set: Add underscores to private attributes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/tests/gl_dynamic_config_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_dynamic_config_unittest.cc b/gpu/command_buffer/tests/gl_dynamic_config_unittest.cc
index 4f661f988d99175d48929fd1607c9028fe08621c..690a5abc9aa7aa4aa79d7e859532fedccf1e69da 100644
--- a/gpu/command_buffer/tests/gl_dynamic_config_unittest.cc
+++ b/gpu/command_buffer/tests/gl_dynamic_config_unittest.cc
@@ -18,7 +18,11 @@ TEST_F(GLDynamicConfigTest, SwitchConfigurationInNonVirtualizedContextMode) {
GLManager::SetEnableVirtualContext(false);
GLManager::Options options;
- options.surface_format = gl::GLSurface::SURFACE_RGB565;
+ // TODO(klausw,jinsukkim): This modification is untested,
+ // GLManager::Options does not currently have a surface_format
+ // field.
+ options.surface_format = gl::GLSurfaceFormat();
+ options.surface_format.SetRGB565();
GLManager gl_rgb_565;
gl_rgb_565.Initialize(options);

Powered by Google App Engine
This is Rietveld 408576698