Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: media/base/pipeline_impl.h

Issue 2616703002: Fix race condition in media Pipeline::GetMediaTime() after seeking. (Closed)
Patch Set: Fix SharedState. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/pipeline_impl.cc » ('j') | media/base/pipeline_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl.h
diff --git a/media/base/pipeline_impl.h b/media/base/pipeline_impl.h
index 624e3e71ccb87a2d383629a51ba1e3e1cd3f6f93..e7e1985ac3e10debc507f52bf3924a5b8e3ae565 100644
--- a/media/base/pipeline_impl.h
+++ b/media/base/pipeline_impl.h
@@ -173,6 +173,11 @@ class MEDIA_EXPORT PipelineImpl : public Pipeline {
// reported to JavaScript from going backwards in time.
mutable base::TimeDelta last_media_time_;
+ // Set by Seek(), used in place of asking the renderer for current media time
+ // while a seek is pending. Renderer's time cannot be trusted until the seek
+ // has completed.
+ base::TimeDelta pending_seek_time_;
sandersd (OOO until July 31) 2017/01/04 21:10:23 Nit: rename to |seek_time_| to match WMPI.
chcunningham 2017/01/04 21:15:47 Done.
+
base::ThreadChecker thread_checker_;
base::WeakPtrFactory<PipelineImpl> weak_factory_;
« no previous file with comments | « no previous file | media/base/pipeline_impl.cc » ('j') | media/base/pipeline_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698