Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 26167002: Make skia almost compile again with clang. (Closed)

Created:
7 years, 2 months ago by tfarina
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make skia almost compile again with clang. clang is reporting many unused functions and variables. R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=11630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M src/core/Sk64.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkAAClip.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M src/core/SkMatrix.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkQuadClipper.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M src/core/SkRTree.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkMatrix44.cpp View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
It is also reporting this: ../../src/utils/SkParseColor.cpp:35:3: error: variable 'colorNames' is not needed and will not ...
7 years, 2 months ago (2013-10-06 02:55:59 UTC) #1
reed1
lgtm
7 years, 2 months ago (2013-10-07 13:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/26167002/1
7 years, 2 months ago (2013-10-07 13:46:01 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 15:52:17 UTC) #4
Message was sent while issue was closed.
Change committed as 11630

Powered by Google App Engine
This is Rietveld 408576698