Use elements/types.dart in codegen.dart

Use elements/types.dart in codegen.dart

+ use raw type in HTypeInfoExpression/INSTANCE to simplify invariants

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/321dad5711f05aea6caf27440dcc1ace94421017

[Johnni Winther, 2017-01-04 15:56:56]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com, sra@google.com

[sra1, 2017-01-04 17:16:03]

https://codereview.chromium.org/2616653003/diff/1/pkg/compiler/lib/src/ssa/no...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2616653003/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3296: /// the INSTANCE form must be a raw
type of some class.
Can we avoid this change?
It breaks the invariant that each type variable in the dartType corresponds to
an input.

INSTANCE/COMPLETE is an unfortunate distinction because the *current* reified
representation is 'headless', with the outermost term being implicit.  This will
change if/when we store a complete reified type (e.g see TODO below).

Type-forwarding optimizations rely on being able to call asInstanceOf, which
gives different results for raw- and this- types.

https://codereview.chromium.org/2616653003/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3330: : super(inputs, instructionType) {
We could assert here that the number of type variables in dartType corresponds
to the number of inputs.

[Johnni Winther, 2017-01-06 10:24:05]

PTAL

https://codereview.chromium.org/2616653003/diff/1/pkg/compiler/lib/src/ssa/no...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2616653003/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3296: /// the INSTANCE form must be a raw
type of some class.
On 2017/01/04 17:16:03, sra1 wrote:
> Can we avoid this change?
> It breaks the invariant that each type variable in the dartType corresponds to
> an input.
> 
> INSTANCE/COMPLETE is an unfortunate distinction because the *current* reified
> representation is 'headless', with the outermost term being implicit.  This
will
> change if/when we store a complete reified type (e.g see TODO below).
> 
> Type-forwarding optimizations rely on being able to call asInstanceOf, which
> gives different results for raw- and this- types.

Done.

https://codereview.chromium.org/2616653003/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3330: : super(inputs, instructionType) {
On 2017/01/04 17:16:03, sra1 wrote:
> We could assert here that the number of type variables in dartType corresponds
> to the number of inputs.

Done.

[sra1, 2017-01-06 17:40:55]

Thanks!
LGTM

[Johnni Winther, 2017-01-09 09:21:05]

Description was changed from

==========
Use elements/types.dart in codegen.dart

+ use raw type in HTypeInfoExpression/INSTANCE to simplify invariants
==========

to

==========
Use elements/types.dart in codegen.dart

+ use raw type in HTypeInfoExpression/INSTANCE to simplify invariants

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/321dad5711f05aea6caf27440dcc1ace94421017
==========

[Johnni Winther, 2017-01-09 09:21:06]

Committed patchset #3 (id:40001) manually as
321dad5711f05aea6caf27440dcc1ace94421017 (presubmit successful).