Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: components/safe_browsing/base_safe_browsing_resource_throttle.cc

Issue 2616653002: Have a list of pending checks instead of pending clients (Closed)
Patch Set: git rebase manually! ugh. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/base_safe_browsing_resource_throttle.cc
diff --git a/components/safe_browsing/base_safe_browsing_resource_throttle.cc b/components/safe_browsing/base_safe_browsing_resource_throttle.cc
index 6058d1b8f3c0a913cc0d984e97eaec2375e7cf22..02089cebbcb28cb52a73b5847fe87e9aa908ac09 100644
--- a/components/safe_browsing/base_safe_browsing_resource_throttle.cc
+++ b/components/safe_browsing/base_safe_browsing_resource_throttle.cc
@@ -238,9 +238,10 @@ void BaseSafeBrowsingResourceThrottle::OnCheckBrowseUrlResult(
CHECK(url.is_valid());
CHECK(url_being_checked_.is_valid());
if (url != url_being_checked_) {
- char buf[2000];
- snprintf(buf, sizeof(buf), "sbtr::ocbur:%s -- %s\n", url.spec().c_str(),
- url_being_checked_.spec().c_str());
+ bool url_had_timed_out = timed_out_urls_.count(url) > 0;
+ char buf[1000];
+ snprintf(buf, sizeof(buf), "sbtr::ocbur:%d:%s -- %s\n", url_had_timed_out,
+ url.spec().c_str(), url_being_checked_.spec().c_str());
base::debug::Alias(buf);
CHECK(false) << "buf: " << buf;
}
@@ -413,6 +414,8 @@ void BaseSafeBrowsingResourceThrottle::OnCheckUrlTimeout() {
OnCheckBrowseUrlResult(url_being_checked_, safe_browsing::SB_THREAT_TYPE_SAFE,
safe_browsing::ThreatMetadata());
+
+ timed_out_urls_.insert(url_being_checked_);
}
void BaseSafeBrowsingResourceThrottle::ResumeRequest() {

Powered by Google App Engine
This is Rietveld 408576698