Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: ios/web/web_state/ui/crw_web_controller_container_view.mm

Issue 2616633003: Fix crash in StaticHTMLNativeContent when deallocating WKWebView on iOS9 (Closed)
Patch Set: no dismiss -> close call Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller_container_view.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_container_view.mm b/ios/web/web_state/ui/crw_web_controller_container_view.mm
index 6db54aca76abce7987e5d72abb308fd04cd71d62..cc311568aa085529b38bc76e0ce2e8e674f0c426 100644
--- a/ios/web/web_state/ui/crw_web_controller_container_view.mm
+++ b/ios/web/web_state/ui/crw_web_controller_container_view.mm
@@ -146,6 +146,9 @@
}
- (void)dealloc {
+ if ([_nativeController respondsToSelector:@selector(willBeDismissed)]) {
+ [_nativeController willBeDismissed];
Eugene But (OOO till 7-30) 2017/01/04 21:24:38 Calling |willBeDismissed| from dealloc does not se
Olivier 2017/01/06 10:03:24 Done.
+ }
self.contentViewProxy.contentView = nil;
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698