ios/chrome/browser/ui/browser_view_controller.mm - Issue 2616633003: Fix crash in StaticHTMLNativeContent when deallocating WKWebView on iOS9

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2616633003: Fix crash in StaticHTMLNativeContent when deallocating WKWebView on iOS9 (Closed)

Patch Set: no dismiss -> close call Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 663810736aade11d923e3ecf04676f57e366edd0..dba26efc255093fb1f866eea27f75fb741f7dd64 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -2750,7 +2750,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

OverscrollActionsController* controller =

[[[OverscrollActionsController alloc]

initWithScrollView:[nativeContent scrollView]] autorelease];

- [[nativeContent scrollView] setDelegate:controller];

[controller setDelegate:self];

OverscrollStyle style = _isOffTheRecord

? OverscrollStyle::REGULAR_PAGE_INCOGNITO