Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2616633002: Respect time range in browsing data removal for last-visited data. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
index b022e8e3309b73a00a29861a9dfddd7129cd8b61..196cff3dc974da3866a8e1b2a86faa7b1692b1a1 100644
--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
@@ -7,6 +7,8 @@
#include <vector>
+#include "base/callback.h"
+
class GURL;
namespace base {
@@ -67,8 +69,12 @@ std::vector<const bookmarks::BookmarkNode*> GetRecentlyVisitedBookmarks(
std::vector<const bookmarks::BookmarkNode*> GetDismissedBookmarksForDebugging(
bookmarks::BookmarkModel* bookmark_model);
-// Removes last visited date metadata for all bookmarks.
-void RemoveAllLastVisitDates(bookmarks::BookmarkModel* bookmark_model);
+// Removes last-visited data (incl. any other metadata managed by content
+// suggestions) for bookmarks within the provided time range.
+void RemoveLastVisitedDatesBetween(const base::Time& begin,
+ const base::Time& end,
+ base::Callback<bool(const GURL& url)> filter,
+ bookmarks::BookmarkModel* bookmark_model);
} // namespace ntp_snippets

Powered by Google App Engine
This is Rietveld 408576698