Respect time range in browsing data removal for last-visited data.

chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
 
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browsing_data/browsing_data_filter_builder.h"
@@ skipping 275 matching lines @@
 
     // Currently, ContentSuggestionService instance exists only on Android.
     ntp_snippets::ContentSuggestionsService* content_suggestions_service =
         ContentSuggestionsServiceFactory::GetForProfileIfExists(profile_);
     if (content_suggestions_service) {
       content_suggestions_service->ClearHistory(delete_begin_, delete_end_,
                                                 filter);
     }
 
     // Remove the last visit dates meta-data from the bookmark model.
     // TODO(vitaliii): Do not remove all dates, but only the ones matched by the

[msramek, 2017/01/04 11:47:12]

nit: This TODO seems to be addressed.

[tschumann, 2017/01/04 13:32:32]

Done.

     // time range and the filter.
     bookmarks::BookmarkModel* bookmark_model =
         BookmarkModelFactory::GetForBrowserContext(profile_);
-    if (bookmark_model)
-        ntp_snippets::RemoveAllLastVisitDates(bookmark_model);
+    if (bookmark_model) {
+      ntp_snippets::RemoveLastVisitedDatesBetween(delete_begin_, delete_end_,

[msramek, 2017/01/04 11:47:12]

Could you update BrowsingDataRemoverTest? You can use
AddURLWithCreationTimeAndMetaInfo to add entries with timestamps in the past.

[tschumann, 2017/01/04 13:32:32]

Done. Deeper test coverage is in bookmark_last_visit_utils_unittest.

+                                                  filter, bookmark_model);
+    }
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
     // The extension activity log contains details of which websites extensions
     // were active on. It therefore indirectly stores details of websites a
     // user has visited so best clean from here as well.
     // TODO(msramek): Support all backends with filter (crbug.com/589586).
     extensions::ActivityLog::GetInstance(profile_)->RemoveURLs(
         std::set<GURL>());
 
     // Clear launch times as they are a form of history.
@@ skipping 535 matching lines @@
 
 #if defined(OS_CHROMEOS)
 void ChromeBrowsingDataRemoverDelegate::OnClearPlatformKeys(
     chromeos::DBusMethodCallStatus call_status,
     bool result) {
   LOG_IF(ERROR, call_status != chromeos::DBUS_METHOD_CALL_SUCCESS || !result)
       << "Failed to clear platform keys.";
   clear_platform_keys_.GetCompletionCallback().Run();
 }
 #endif