Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2616623002: Do not send redundant selectionchange-events (decouple focus) (Closed)
Patch Set: Adjust Android-tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index 561a2d967cce810899fa1b1e553fb6777ec9f9e2..47bb32cad2fd0e9ed5accc0c974c28fff6f91ef7 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -667,7 +667,7 @@ public class ImeTest extends ContentShellTestBase {
assertWaitForSelectActionBarStatus(true);
DOMUtils.clickNode(this, mContentViewCore, "input_radio");
assertWaitForKeyboardStatus(false);
- assertWaitForSelectActionBarStatus(false);
+ assertWaitForSelectActionBarStatus(true);
hugoh_UTC2 2017/01/18 09:20:03 I flipped this boolean just to make the test pass.
}
@SmallTest
@@ -1199,7 +1199,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_ComposingText() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
setComposingText("a", 1);
@@ -1237,7 +1237,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_CommitText() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
commitText("a", 1);
@@ -1259,7 +1259,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_DeleteSurroundingText() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
commitText("hello", 1);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698