content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 2616623002: Do not send redundant selectionchange-events (decouple focus)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2616623002: Do not send redundant selectionchange-events (decouple focus) (Closed)

Patch Set: Early return false x 2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index 8f091650ecea98e254a474921d934e90c8c5927d..297267065c14a50a39c7abd7f3028f9024afd606 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -785,7 +785,7 @@ public class ImeTest extends ContentShellTestBase {

DOMUtils.longPressNode(mContentViewCore, "input_text");

assertWaitForKeyboardStatus(true);

assertWaitForSelectActionBarStatus(true);

- DOMUtils.clickNode(mContentViewCore, "input_radio");

+ DOMUtils.clickNode(mContentViewCore, "plain_text");

assertWaitForKeyboardStatus(false);

assertWaitForSelectActionBarStatus(false);

}

@@ -1317,7 +1317,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_ComposingText() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

setComposingText("a", 1);

@@ -1352,7 +1352,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_CommitText() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

commitText("a", 1);

@@ -1374,7 +1374,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_DeleteSurroundingText() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

commitText("hello", 1);

@@ -1416,7 +1416,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_DeleteSurroundingTextInCodePoints() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

commitText("hello", 1);

« no previous file with comments | « no previous file | content/test/data/android/input/input_forms.html » ('j') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('J')