Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2616623002: Do not send redundant selectionchange-events (decouple focus) (Closed)
Patch Set: Move isSelectionInDocument() and selectionHasFocus() to EditingUtilities Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index d4e2547c6cbccdacc577ee415ea45402b3a5df82..87b8ab780d2674a562d04a954951a423a103a18d 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -785,7 +785,7 @@ public class ImeTest extends ContentShellTestBase {
DOMUtils.longPressNode(mContentViewCore, "input_text");
assertWaitForKeyboardStatus(true);
assertWaitForSelectActionBarStatus(true);
- DOMUtils.clickNode(mContentViewCore, "input_radio");
+ DOMUtils.clickNode(mContentViewCore, "plain_text");
assertWaitForKeyboardStatus(false);
assertWaitForSelectActionBarStatus(false);
}
@@ -1318,7 +1318,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_ComposingText() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
setComposingText("a", 1);
@@ -1353,7 +1353,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_CommitText() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
commitText("a", 1);
@@ -1375,7 +1375,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_DeleteSurroundingText() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
commitText("hello", 1);
@@ -1417,7 +1417,7 @@ public class ImeTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testContentEditableEvents_DeleteSurroundingTextInCodePoints() throws Throwable {
focusElementAndWaitForStateUpdate("contenteditable_event");
- waitForEventLogs("selectionchange,selectionchange");
+ waitForEventLogs("selectionchange");
clearEventLogs();
commitText("hello", 1);

Powered by Google App Engine
This is Rietveld 408576698