content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 2616623002: Do not send redundant selectionchange-events (decouple focus)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2616623002: Do not send redundant selectionchange-events (decouple focus) (Closed)

Patch Set: Fix spatnav tests (clear selection when focus goes to non editable element). Remove now invalid kee… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index 9401829c213ade4070d443b75bc2b5dd1f073fb8..520bcfd9a1772d05e846b71978485ffb853244bc 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -721,7 +721,7 @@ public class ImeTest extends ContentShellTestBase {

DOMUtils.longPressNode(this, mContentViewCore, "input_text");

assertWaitForKeyboardStatus(true);

assertWaitForSelectActionBarStatus(true);

- DOMUtils.clickNode(this, mContentViewCore, "input_radio");

+ DOMUtils.clickNode(this, mContentViewCore, "plain_text");

assertWaitForKeyboardStatus(false);

assertWaitForSelectActionBarStatus(false);

}

@@ -1255,7 +1255,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_ComposingText() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

setComposingText("a", 1);

@@ -1290,7 +1290,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_CommitText() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

commitText("a", 1);

@@ -1312,7 +1312,7 @@ public class ImeTest extends ContentShellTestBase {

@Feature({"TextInput"})

public void testContentEditableEvents_DeleteSurroundingText() throws Throwable {

focusElementAndWaitForStateUpdate("contenteditable_event");

- waitForEventLogs("selectionchange,selectionchange");

+ waitForEventLogs("selectionchange");

clearEventLogs();

commitText("hello", 1);

« no previous file with comments | « no previous file | content/test/data/android/input/input_forms.html » ('j') | third_party/WebKit/Source/core/dom/Element.cpp » ('J')