Do not send redundant selectionchange-events (decouple focus)

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 67 matching lines @@
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/ThreadableLoader.h"
 #include "core/page/Page.h"
 #include "core/page/ScopedPageSuspender.h"
 #include "core/paint/PaintLayer.h"
 #include "core/testing/NullExecutionContext.h"
 #include "modules/mediastream/MediaStream.h"
 #include "modules/mediastream/MediaStreamRegistry.h"
 #include "platform/Cursor.h"
 #include "platform/DragImage.h"
+#include "platform/KeyboardCodes.h"
 #include "platform/PlatformResourceLoader.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/loader/fetch/FetchRequest.h"
 #include "platform/loader/fetch/MemoryCache.h"
 #include "platform/loader/fetch/ResourceFetcher.h"
 #include "platform/network/ResourceError.h"
 #include "platform/scroll/Scrollbar.h"
 #include "platform/scroll/ScrollbarTestSuite.h"
 #include "platform/scroll/ScrollbarTheme.h"
 #include "platform/scroll/ScrollbarThemeMock.h"
 #include "platform/scroll/ScrollbarThemeOverlayMock.h"
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "platform/weborigin/KURLHash.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCache.h"
 #include "public/platform/WebCachePolicy.h"
 #include "public/platform/WebClipboard.h"
 #include "public/platform/WebFloatRect.h"
+#include "public/platform/WebKeyboardEvent.h"
 #include "public/platform/WebMockClipboard.h"
 #include "public/platform/WebSecurityOrigin.h"
 #include "public/platform/WebThread.h"
 #include "public/platform/WebURL.h"
 #include "public/platform/WebURLLoaderClient.h"
 #include "public/platform/WebURLLoaderMockFactory.h"
 #include "public/platform/WebURLResponse.h"
 #include "public/web/WebConsoleMessage.h"
 #include "public/web/WebDataSource.h"
 #include "public/web/WebDeviceEmulationParams.h"
@@ skipping 4128 matching lines @@
   webViewHelper.initializeAndLoad(
       m_baseURL + "iframe_clear_focused_node_test.html", true);
 
   // Clear the focused node.
   webViewHelper.webView()->clearFocusedElement();
 
   // Now retrieve the FocusedNode and test it should be null.
   EXPECT_EQ(0, webViewHelper.webView()->focusedElement());
 }
 
+class ChangedSelectionCounter : public FrameTestHelpers::TestWebFrameClient {
+ public:
+  ChangedSelectionCounter() : m_callCount(0) {}
+  void didChangeSelection(bool isSelectionEmpty) { ++m_callCount; }
+  int count() const { return m_callCount; }
+  void reset() { m_callCount = 0; }
+
+ private:
+  int m_callCount;
+};
+
+TEST_P(ParameterizedWebFrameTest, TabKeyCursorMoveTriggersOneSelectionChange) {
+  ChangedSelectionCounter counter;
+  FrameTestHelpers::WebViewHelper webViewHelper;
+  registerMockedHttpURLLoad("editable_elements.html");
+  WebViewImpl* webView = webViewHelper.initializeAndLoad(
+      m_baseURL + "editable_elements.html", true, &counter);
+
+  WebKeyboardEvent tabDownEvent(WebInputEvent::KeyDown,
+                                WebInputEvent::NoModifiers,
+                                WebInputEvent::TimeStampForTesting);
+  WebKeyboardEvent tabUpEvent(WebInputEvent::KeyUp, WebInputEvent::NoModifiers,
+                              WebInputEvent::TimeStampForTesting);
+  tabDownEvent.domKey = Platform::current()->domKeyEnumFromString("\t");
+  tabUpEvent.domKey = Platform::current()->domKeyEnumFromString("\t");
+  tabDownEvent.windowsKeyCode = VKEY_TAB;
+  tabUpEvent.windowsKeyCode = VKEY_TAB;
+
+  // Move to the next text-field: 1 cursor change.
+  counter.reset();
+  webView->handleInputEvent(WebCoalescedInputEvent(tabDownEvent));
+  webView->handleInputEvent(WebCoalescedInputEvent(tabUpEvent));
+  EXPECT_EQ(1, counter.count());
+
+  // Move to another text-field: 1 cursor change.
+  webView->handleInputEvent(WebCoalescedInputEvent(tabDownEvent));
+  webView->handleInputEvent(WebCoalescedInputEvent(tabUpEvent));
+  EXPECT_EQ(2, counter.count());
+
+  // Move to a number-field: 1 cursor change.
+  webView->handleInputEvent(WebCoalescedInputEvent(tabDownEvent));
+  webView->handleInputEvent(WebCoalescedInputEvent(tabUpEvent));
+  EXPECT_EQ(3, counter.count());
+
+  // Move to an editable element: 1 cursor change.
+  webView->handleInputEvent(WebCoalescedInputEvent(tabDownEvent));
+  webView->handleInputEvent(WebCoalescedInputEvent(tabUpEvent));
+  EXPECT_EQ(4, counter.count());
+
+  // Move to a non-editable element: 0 cursor changes.
+  // TODO(blink-editing): Once we've fixed crbug.com/692898 test this too:

[yosin_UTC9, 2017/03/21 06:49:59]

nit: s/blink-editing/editing-dev/

[hugoh_UTC2, 2017/03/22 02:54:47]

Done.

+  //  webView->handleInputEvent(WebCoalescedInputEvent(tabDownEvent));
+  //  webView->handleInputEvent(WebCoalescedInputEvent(tabUpEvent));
+  //  EXPECT_EQ(4, counter.count());
+}
+
 // Implementation of WebFrameClient that tracks the v8 contexts that are created
 // and destroyed for verification.
 class ContextLifetimeTestWebFrameClient
     : public FrameTestHelpers::TestWebFrameClient {
  public:
   struct Notification {
    public:
     Notification(WebLocalFrame* frame,
                  v8::Local<v8::Context> context,
                  int worldId)
@@ skipping 7092 matching lines @@
   FrameTestHelpers::WebViewHelper openerHelper;
   openerHelper.initialize(false, nullptr, &openerWebViewClient);
   FrameTestHelpers::WebViewHelper helper;
   helper.initializeWithOpener(openerHelper.webView()->mainFrame());
 
   openerHelper.reset();
   EXPECT_EQ(nullptr, helper.webView()->mainFrameImpl()->opener());
 }
 
 }  // namespace blink