Do not send redundant selectionchange-events (decouple focus)

third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 1870 matching lines @@
   return frame.editor().canDHTMLCut() || frame.editor().canCut();
 }
 
 static bool enabledInEditableText(LocalFrame& frame,
                                   Event* event,
                                   EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
   return frame.editor().selectionForCommand(event).rootEditableElement();
 }
 
+static bool enabledInFocusedEditableText(LocalFrame& frame,
+                                         Event* event,
+                                         EditorCommandSource dummy) {
+  if (!enabledInEditableText(frame, event, dummy))
+    return false;
+
+  // We only move carret when the carret's selection has focus.
+  return selectionHasFocus(frame);
+}
+
 static bool enabledDelete(LocalFrame& frame,
                           Event* event,
                           EditorCommandSource source) {
   switch (source) {
     case CommandFromMenuOrKeyBinding:
       return frame.editor().canDelete();
     case CommandFromDOM:
       // "Delete" from DOM is like delete/backspace keypress, affects selected
       // range if non-empty, otherwise removes a character
       return enabledInEditableText(frame, event, source);
@@ skipping 353 matching lines @@
        supportedFromMenuOrKeyBinding, enabledInRichlyEditableText,
        stateTextWritingDirectionRightToLeft, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveBackward, executeMoveBackward,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveBackwardAndModifySelection,
        executeMoveBackwardAndModifySelection, supportedFromMenuOrKeyBinding,
        enabledVisibleSelection, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveDown, executeMoveDown,

[yosin_UTC9, 2017/03/21 06:49:59]

Should we change of Move{Paragraph,Word,...}{Back,For}ward() too?
It is nice if we can move "EditorCommand.cpp", w/ tests, in another patch.

[hugoh_UTC2, 2017/03/22 02:54:47]

I introduced these changes to make LayoutTests/fast/spatial-navigation pass. Now
that we postpone fixing selectionchange of spatnav (see comment in
FocusController::advanceFocusDirectionallyInContainer) the changes in this file
might not be needed until we tackle crbug.com/692898. I try this in PS24.

-       supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
+       supportedFromMenuOrKeyBinding, enabledInFocusedEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveDownAndModifySelection,
        executeMoveDownAndModifySelection, supportedFromMenuOrKeyBinding,
        enabledVisibleSelection, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveForward, executeMoveForward,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveForwardAndModifySelection,
        executeMoveForwardAndModifySelection, supportedFromMenuOrKeyBinding,
        enabledVisibleSelection, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveLeft, executeMoveLeft,
-       supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
+       supportedFromMenuOrKeyBinding, enabledInFocusedEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveLeftAndModifySelection,
        executeMoveLeftAndModifySelection, supportedFromMenuOrKeyBinding,
        enabledVisibleSelection, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MovePageDown, executeMovePageDown,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MovePageDownAndModifySelection,
        executeMovePageDownAndModifySelection, supportedFromMenuOrKeyBinding,
@@ skipping 15 matching lines @@
        supportedFromMenuOrKeyBinding, enabledVisibleSelection, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveParagraphForward, executeMoveParagraphForward,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveParagraphForwardAndModifySelection,
        executeMoveParagraphForwardAndModifySelection,
        supportedFromMenuOrKeyBinding, enabledVisibleSelection, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveRight, executeMoveRight,
-       supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
+       supportedFromMenuOrKeyBinding, enabledInFocusedEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveRightAndModifySelection,
        executeMoveRightAndModifySelection, supportedFromMenuOrKeyBinding,
        enabledVisibleSelection, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveToBeginningOfDocument,
        executeMoveToBeginningOfDocument, supportedFromMenuOrKeyBinding,
        enabledInEditableText, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveToBeginningOfDocumentAndModifySelection,
@@ skipping 60 matching lines @@
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveToRightEndOfLine, executeMoveToRightEndOfLine,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveToRightEndOfLineAndModifySelection,
        executeMoveToRightEndOfLineAndModifySelection,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveUp, executeMoveUp,
-       supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
+       supportedFromMenuOrKeyBinding, enabledInFocusedEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveUpAndModifySelection,
        executeMoveUpAndModifySelection, supportedFromMenuOrKeyBinding,
        enabledVisibleSelection, stateNone, valueNull, notTextInsertion,
        doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveWordBackward, executeMoveWordBackward,
        supportedFromMenuOrKeyBinding, enabledInEditableText, stateNone,
        valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled},
       {WebEditingCommandType::MoveWordBackwardAndModifySelection,
        executeMoveWordBackwardAndModifySelection, supportedFromMenuOrKeyBinding,
@@ skipping 345 matching lines @@
           *m_frame, DirectionBackward, WordGranularity);
     case WebEditingCommandType::DeleteWordForward:
       return RangesFromCurrentSelectionOrExtendCaret(*m_frame, DirectionForward,
                                                      WordGranularity);
     default:
       return targetRangesForInputEvent(*target);
   }
 }
 
 }  // namespace blink