Do not send redundant selectionchange-events (decouple focus)

content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.app.Activity;
 import android.content.ClipData;
 import android.content.ClipboardManager;
 import android.content.Context;
@@ skipping 647 matching lines @@
         assertWaitForSelectActionBarStatus(false);
     }
 
     @SmallTest
     @Feature({"TextInput"})
     public void testSelectActionBarClearedOnTappingOutsideInput() throws Exception {
         commitText("Sample Text", 1);
         DOMUtils.longPressNode(this, mContentViewCore, "input_text");
         assertWaitForKeyboardStatus(true);
         assertWaitForSelectActionBarStatus(true);
         DOMUtils.clickNode(this, mContentViewCore, "input_radio");

[aelias_OOO_until_Jul13, 2017/01/24 00:51:41]

I can't repro any obvious change to action bar behavior when trying out locally,
and radio button scenario doesn't really matter, so I think the test is
unnecessarily specific.  I suggest changing to "plain_text" and also adding an
additional <br/> above the "plain_text" element in input_forms.html (because
touch adjustment fudge factor would cause such taps to hit nearby input box
otherwise); I tested locally the test passes with that.

         assertWaitForKeyboardStatus(false);
-        assertWaitForSelectActionBarStatus(false);
+        assertWaitForSelectActionBarStatus(true);
     }
 
     @SmallTest
     @Feature({"TextInput"})
     public void testImeNotShownOnLongPressingDifferentEmptyInputs() throws Exception {
         DOMUtils.focusNode(mWebContents, "input_radio");
         DOMUtils.longPressNode(this, mContentViewCore, "input_text");
         assertWaitForKeyboardStatus(false);
         DOMUtils.longPressNode(this, mContentViewCore, "textarea");
         assertWaitForKeyboardStatus(false);
@@ skipping 511 matching lines @@
     public void testRestartInputKeepsTextAndCursor() throws Exception {
         commitText("ab", 2);
         restartInput();
         assertEquals("ab", getTextBeforeCursor(10, 0));
     }
 
     @MediumTest
     @Feature({"TextInput"})
     public void testContentEditableEvents_ComposingText() throws Throwable {
         focusElementAndWaitForStateUpdate("contenteditable_event");
-        waitForEventLogs("selectionchange,selectionchange");
+        waitForEventLogs("selectionchange");
         clearEventLogs();
 
         setComposingText("a", 1);
         waitAndVerifyUpdateSelection(0, 1, 1, 0, 1);
         // TODO(changwan): reduce the number of selection changes.
         waitForEventLogs("keydown(229),compositionstart(),compositionupdate(a),input,keyup(229),"
                 + "selectionchange,selectionchange");
         clearEventLogs();
 
         finishComposingText();
@@ skipping 17 matching lines @@
         waitAndVerifyUpdateSelection(1, 1, 1, -1, -1);
         // TODO(changwan): reduce the number of selection changes.
         waitForEventLogs("compositionupdate(a),input,compositionend(a),selectionchange,"
                 + "selectionchange,selectionchange");
     }
 
     @MediumTest
     @Feature({"TextInput"})
     public void testContentEditableEvents_CommitText() throws Throwable {
         focusElementAndWaitForStateUpdate("contenteditable_event");
-        waitForEventLogs("selectionchange,selectionchange");
+        waitForEventLogs("selectionchange");
         clearEventLogs();
 
         commitText("a", 1);
         waitAndVerifyUpdateSelection(0, 1, 1, -1, -1);
 
         waitForEventLogs("keydown(229),input,keyup(229),selectionchange");
     }
 
     @MediumTest
     @Feature({"TextInput"})
     public void testInputTextEvents_CommitText() throws Throwable {
         commitText("a", 1);
         waitAndVerifyUpdateSelection(0, 1, 1, -1, -1);
 
         waitForEventLogs("keydown(229),input,keyup(229),selectionchange");
     }
 
     @MediumTest
     @Feature({"TextInput"})
     public void testContentEditableEvents_DeleteSurroundingText() throws Throwable {
         focusElementAndWaitForStateUpdate("contenteditable_event");
-        waitForEventLogs("selectionchange,selectionchange");
+        waitForEventLogs("selectionchange");
         clearEventLogs();
 
         commitText("hello", 1);
         waitAndVerifyUpdateSelection(0, 5, 5, -1, -1);
         waitForEventLogs("keydown(229),input,keyup(229),selectionchange");
         clearEventLogs();
 
         setSelection(2, 2);
         waitAndVerifyUpdateSelection(1, 2, 2, -1, -1);
         waitForEventLogs("selectionchange");
@@ skipping 533 matching lines @@
         public void onViewAttachedToWindow() {
             mFactory.onViewAttachedToWindow();
         }
 
         @Override
         public void onViewDetachedFromWindow() {
             mFactory.onViewDetachedFromWindow();
         }
     }
 }