Fix calculation of abspos style properties: left/padding/width/height...

third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_absolute_utils.h"
 
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_length_utils.h"
 #include "core/style/ComputedStyle.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 93 matching lines @@
   LayoutUnit border_left(9);
   LayoutUnit padding_left(11);
   LayoutUnit right(13);
   LayoutUnit margin_right(15);
   LayoutUnit border_right(17);
   LayoutUnit padding_right(19);
 
   LayoutUnit width =
       container_size_.inline_size - left - margin_left - right - margin_right;
 
-  Optional<LayoutUnit> estimated_inline;
+  Optional<MinAndMaxContentSizes> estimated_inline;
+  MinAndMaxContentSizes minmax_60{LayoutUnit(60), LayoutUnit(60)};
 
   style_->setBorderLeftWidth(border_left.toInt());
   style_->setBorderRightWidth(border_right.toInt());
   style_->setPaddingLeft(Length(padding_left.toInt(), LengthType::Fixed));
   style_->setPaddingRight(Length(padding_right.toInt(), LengthType::Fixed));
 
   // These default to 3 which is not what we want.
   style_->setBorderBottomWidth(0);
   style_->setBorderTopWidth(0);
 
   NGAbsolutePhysicalPosition p;
 
   NGStaticPosition static_position{NGStaticPosition::kTopLeft,
                                    {LayoutUnit(), LayoutUnit()}};
   NGStaticPosition static_right_position{NGStaticPosition::kTopRight,
                                          {LayoutUnit(), LayoutUnit()}};
   //
   // Tests.
   //
 
   // All auto => width is estimated_inline, left is 0.
   SetHorizontalStyle(NGAuto, NGAuto, NGAuto, NGAuto, NGAuto);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), true);
-  estimated_inline = LayoutUnit(60);
+  estimated_inline = minmax_60;
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_position, estimated_inline);
-  EXPECT_EQ(*estimated_inline, p.size.width);
+  EXPECT_EQ(minmax_60.min_content, p.size.width);
   EXPECT_EQ(LayoutUnit(0), p.inset.left);
 
   // All auto => width is estimated_inline, static_position is right
   SetHorizontalStyle(NGAuto, NGAuto, NGAuto, NGAuto, NGAuto);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), true);
-  estimated_inline = LayoutUnit(60);
+  estimated_inline = minmax_60;
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_right_position, estimated_inline);
-  EXPECT_EQ(*estimated_inline, p.size.width);
+  EXPECT_EQ(minmax_60.min_content, p.size.width);
   EXPECT_EQ(LayoutUnit(0), p.inset.right);
 
   // All auto + RTL.
   p = ComputePartialAbsoluteWithChildInlineSize(
       *rtl_space_, *style_, static_position, estimated_inline);
-  EXPECT_EQ(*estimated_inline, p.size.width);
-  EXPECT_EQ(container_size_.inline_size - *estimated_inline, p.inset.right);
+  EXPECT_EQ(minmax_60.min_content, p.size.width);
+  EXPECT_EQ(container_size_.inline_size - minmax_60.min_content, p.inset.right);
 
   // left, right, and left are known, compute margins.
   SetHorizontalStyle(left, NGAuto, width, NGAuto, right);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), false);
   estimated_inline.reset();
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_position, estimated_inline);
   LayoutUnit marginSpace =
       (container_size_.inline_size - left - right - p.size.width) / 2;
   EXPECT_EQ(left + marginSpace, p.inset.left);
@@ skipping 29 matching lines @@
   SetHorizontalStyle(left, NGAuto, LayoutUnit(200), NGAuto, right);
   estimated_inline.reset();
   p = ComputePartialAbsoluteWithChildInlineSize(
       *rtl_space_, *style_, static_position, estimated_inline);
   EXPECT_EQ(-right, p.inset.left);
   EXPECT_EQ(right, p.inset.right);
 
   // Rule 1 left and width are auto.
   SetHorizontalStyle(NGAuto, margin_left, NGAuto, margin_right, right);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), true);
-  estimated_inline = LayoutUnit(60);
+  estimated_inline = minmax_60;
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_position, estimated_inline);
-  EXPECT_EQ(*estimated_inline, p.size.width);
+  EXPECT_EQ(minmax_60.min_content, p.size.width);
 
   // Rule 2 left and right are auto LTR.
   SetHorizontalStyle(NGAuto, margin_left, width, margin_right, NGAuto);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), false);
   estimated_inline.reset();
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_position, estimated_inline);
   EXPECT_EQ(margin_left, p.inset.left);
   EXPECT_EQ(container_size_.inline_size - margin_left - width, p.inset.right);
 
   // Rule 2 left and right are auto RTL.
   SetHorizontalStyle(NGAuto, margin_left, width, margin_right, NGAuto);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), false);
   estimated_inline.reset();
   p = ComputePartialAbsoluteWithChildInlineSize(
       *rtl_space_, *style_, static_position, estimated_inline);
   EXPECT_EQ(margin_left, p.inset.left);
   EXPECT_EQ(container_size_.inline_size - margin_left - width, p.inset.right);
 
   // Rule 3 width and right are auto.
   SetHorizontalStyle(left, margin_left, NGAuto, margin_right, NGAuto);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), true);
-  estimated_inline = LayoutUnit(60);
+  estimated_inline = minmax_60;
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_position, estimated_inline);
   EXPECT_EQ(
-      container_size_.inline_size - *estimated_inline - left - margin_left,
+      container_size_.inline_size - minmax_60.min_content - left - margin_left,
       p.inset.right);
-  EXPECT_EQ(*estimated_inline, p.size.width);
+  EXPECT_EQ(minmax_60.min_content, p.size.width);
 
   // Rule 4: left is auto.
   SetHorizontalStyle(NGAuto, margin_left, width, margin_right, right);
   EXPECT_EQ(AbsoluteNeedsChildInlineSize(*style_), false);
   estimated_inline.reset();
   p = ComputePartialAbsoluteWithChildInlineSize(
       *ltr_space_, *style_, static_position, estimated_inline);
   EXPECT_EQ(left + margin_left, p.inset.left);
 
   // Rule 4: left is auto, EBoxSizing::BoxSizingContentBox
@@ skipping 167 matching lines @@
   SetVerticalStyle(top, margin_top, NGAuto, margin_bottom, bottom);
   EXPECT_EQ(AbsoluteNeedsChildBlockSize(*style_), false);
   auto_height.reset();
   ComputeFullAbsoluteWithChildBlockSize(*ltr_space_, *style_, static_position,
                                         auto_height, &p);
   EXPECT_EQ(height, p.size.height);
 }
 
 }  // namespace
 }  // namespace blink