Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: third_party/WebKit/LayoutTests/transitions/unprefixed-perspective-origin.html

Issue 2616603003: CSS Transitions: Fix flaky unprefixed-perspective-origin.html (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/transitions/unprefixed-perspective-origin.html
diff --git a/third_party/WebKit/LayoutTests/transitions/unprefixed-perspective-origin.html b/third_party/WebKit/LayoutTests/transitions/unprefixed-perspective-origin.html
index cc12035fa6a1bd5d47ce9d49e4f3d1b8571c5d8b..bf2d928b057f2a1cde4d432ff620246681d40cbd 100644
--- a/third_party/WebKit/LayoutTests/transitions/unprefixed-perspective-origin.html
+++ b/third_party/WebKit/LayoutTests/transitions/unprefixed-perspective-origin.html
@@ -5,6 +5,8 @@
<div class="target">-webkit-perspective-origin-x 10ms</div><br>
<div class="target">-webkit-perspective-origin-y 10ms</div><br>
<script>
+'use strict';
+var remaining = 0;
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
@@ -14,11 +16,9 @@ document.addEventListener('transitionend', function(e) {
var result = document.createElement('div');
result.textContent = 'fired transitionend with propertyName: ' + e.propertyName;
e.target.appendChild(result);
- if (window.testRunner) {
- // All events should be fired by next frame.
- requestAnimationFrame(function() {
- testRunner.notifyDone();
- });
+ --remaining;
+ if (remaining === 0 && window.testRunner) {
+ testRunner.notifyDone();
}
});
@@ -30,6 +30,7 @@ onload = function() {
targets[i].style.webkitPerspectiveOriginX = '10px';
targets[i].style.webkitPerspectiveOriginY = '10px';
targets[i].style.perspectiveOrigin = '10px 10px';
+ ++remaining;
}
};
</script>
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698