Issue 26166004: Get rid of HEAP_PROFILE macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26166004: Get rid of HEAP_PROFILE macro (Closed)

Created:
7 years, 2 months ago by yurys

Modified:
7 years, 2 months ago

Reviewers:
alph, Yang, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Get rid of HEAP_PROFILE macro All usages of the macro were replaced with direct calls to the heap profiler. The macro does null check for HeapProfiler which is always true. BUG=None R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17242

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -14 lines)			Patch
M	src/builtins.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/heap-profiler.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

yurys

7 years, 2 months ago (2013-10-16 14:33:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17242 (presubmit successful).