Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8729)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2616573002: Adjust spacing in InternalPageInfoPopupView (Closed)
Patch Set: constexpr Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
index 0f41cca26deb5e8271bcfdac66dde4c4abc8180a..b263e5ba27e0544cf00852c3144fe20b91359422 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
@@ -173,6 +173,9 @@ class InternalPageInfoPopupView : public views::BubbleDialogDelegateView {
private:
friend class WebsiteSettingsPopupView;
+ // Used around icon and inside bubble border.
+ static constexpr int kSpacing = 12;
+
DISALLOW_COPY_AND_ASSIGN(InternalPageInfoPopupView);
};
@@ -354,7 +357,6 @@ InternalPageInfoPopupView::InternalPageInfoPopupView(
set_anchor_view_insets(gfx::Insets(
GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
- const int kSpacing = 16;
SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing,
kSpacing, kSpacing));
set_margins(gfx::Insets());
@@ -379,9 +381,9 @@ views::NonClientFrameView* InternalPageInfoPopupView::CreateNonClientFrameView(
views::Widget* widget) {
views::BubbleFrameView* frame = static_cast<views::BubbleFrameView*>(
BubbleDialogDelegateView::CreateNonClientFrameView(widget));
- // 16px padding + half of icon width comes out to 24px.
+ // Padding around icon + half of icon width.
frame->bubble_border()->set_arrow_offset(
- 24 + frame->bubble_border()->GetBorderThickness());
+ kSpacing + 8 + frame->bubble_border()->GetBorderThickness());
return frame;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698