Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: components/security_state/core/security_state_unittest.cc

Issue 2616553002: Remove obsolete SHA-1 UX elements (Closed)
Patch Set: Address Emily's feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/core/security_state_unittest.cc
diff --git a/components/security_state/core/security_state_unittest.cc b/components/security_state/core/security_state_unittest.cc
index 4e4aa701103218690a47160ca4bceb9296053aee..3be355c2b8c43f9722e531fe7062b7cfd1750fe0 100644
--- a/components/security_state/core/security_state_unittest.cc
+++ b/components/security_state/core/security_state_unittest.cc
@@ -121,8 +121,8 @@ TEST(SecurityStateTest, SHA1Warning) {
TestSecurityStateHelper helper;
SecurityInfo security_info;
helper.GetSecurityInfo(&security_info);
- EXPECT_EQ(DEPRECATED_SHA1_MINOR, security_info.sha1_deprecation_status);
- EXPECT_EQ(DANGEROUS, security_info.security_level);
+ EXPECT_EQ(true, security_info.sha1_in_chain);
estark 2017/01/08 16:39:59 nit: EXPECT_TRUE
elawrence 2017/01/09 18:13:12 Done.
+ EXPECT_EQ(NONE, security_info.security_level);
}
// Tests that SHA1 warnings don't interfere with the handling of mixed
@@ -132,15 +132,15 @@ TEST(SecurityStateTest, SHA1WarningMixedContent) {
helper.SetDisplayedMixedContent(true);
SecurityInfo security_info1;
helper.GetSecurityInfo(&security_info1);
- EXPECT_EQ(DEPRECATED_SHA1_MINOR, security_info1.sha1_deprecation_status);
+ EXPECT_EQ(true, security_info1.sha1_in_chain);
estark 2017/01/08 16:39:59 nit: EXPECT_TRUE
elawrence 2017/01/09 18:13:12 Done.
EXPECT_EQ(CONTENT_STATUS_DISPLAYED, security_info1.mixed_content_status);
- EXPECT_EQ(DANGEROUS, security_info1.security_level);
+ EXPECT_EQ(NONE, security_info1.security_level);
helper.SetDisplayedMixedContent(false);
helper.SetRanMixedContent(true);
SecurityInfo security_info2;
helper.GetSecurityInfo(&security_info2);
- EXPECT_EQ(DEPRECATED_SHA1_MINOR, security_info2.sha1_deprecation_status);
+ EXPECT_EQ(true, security_info2.sha1_in_chain);
estark 2017/01/08 16:39:59 nit: EXPECT_TRUE
elawrence 2017/01/09 18:13:11 Done.
EXPECT_EQ(CONTENT_STATUS_RAN, security_info2.mixed_content_status);
EXPECT_EQ(DANGEROUS, security_info2.security_level);
}
@@ -152,7 +152,7 @@ TEST(SecurityStateTest, SHA1WarningBrokenHTTPS) {
helper.AddCertStatus(net::CERT_STATUS_DATE_INVALID);
SecurityInfo security_info;
helper.GetSecurityInfo(&security_info);
- EXPECT_EQ(DEPRECATED_SHA1_MINOR, security_info.sha1_deprecation_status);
+ EXPECT_EQ(true, security_info.sha1_in_chain);
estark 2017/01/08 16:39:59 nit: EXPECT_TRUE
elawrence 2017/01/09 18:13:11 Done.
EXPECT_EQ(DANGEROUS, security_info.security_level);
}

Powered by Google App Engine
This is Rietveld 408576698