Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings_unittest.cc

Issue 2616553002: Remove obsolete SHA-1 UX elements (Closed)
Patch Set: Fixup WebsiteSettingsTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/website_settings.h" 5 #include "chrome/browser/ui/website_settings/website_settings.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/at_exit.h" 10 #include "base/at_exit.h"
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 SetDefaultUIExpectations(mock_ui()); 609 SetDefaultUIExpectations(mock_ui());
610 EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION)); 610 EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));
611 611
612 EXPECT_EQ(WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED, 612 EXPECT_EQ(WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED,
613 website_settings()->site_connection_status()); 613 website_settings()->site_connection_status());
614 EXPECT_EQ(WebsiteSettings::SITE_IDENTITY_STATUS_ADMIN_PROVIDED_CERT, 614 EXPECT_EQ(WebsiteSettings::SITE_IDENTITY_STATUS_ADMIN_PROVIDED_CERT,
615 website_settings()->site_identity_status()); 615 website_settings()->site_identity_status());
616 EXPECT_EQ(base::string16(), website_settings()->organization_name()); 616 EXPECT_EQ(base::string16(), website_settings()->organization_name());
617 } 617 }
618 618
619 TEST_F(WebsiteSettingsTest, HTTPSSHA1Minor) { 619 TEST_F(WebsiteSettingsTest, HTTPSSHA1) {
620 security_info_.security_level = security_state::NONE; 620 security_info_.security_level = security_state::NONE;
621 security_info_.scheme_is_cryptographic = true; 621 security_info_.scheme_is_cryptographic = true;
622 security_info_.certificate = cert(); 622 security_info_.certificate = cert();
623 security_info_.cert_status = 0; 623 security_info_.cert_status = 0;
624 security_info_.security_bits = 81; // No error if > 80. 624 security_info_.security_bits = 81; // No error if > 80.
625 int status = 0; 625 int status = 0;
626 status = SetSSLVersion(status, net::SSL_CONNECTION_VERSION_TLS1); 626 status = SetSSLVersion(status, net::SSL_CONNECTION_VERSION_TLS1);
627 status = SetSSLCipherSuite(status, CR_TLS_RSA_WITH_AES_256_CBC_SHA256); 627 status = SetSSLCipherSuite(status, CR_TLS_RSA_WITH_AES_256_CBC_SHA256);
628 security_info_.connection_status = status; 628 security_info_.connection_status = status;
629 security_info_.sha1_deprecation_status = 629 security_info_.sha1_deprecation_status = security_state::DEPRECATED_SHA1;
630 security_state::DEPRECATED_SHA1_MINOR;
631 630
632 SetDefaultUIExpectations(mock_ui()); 631 SetDefaultUIExpectations(mock_ui());
633 EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION)); 632 EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));
634 633
635 EXPECT_EQ(WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED, 634 EXPECT_EQ(WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED,
636 website_settings()->site_connection_status()); 635 website_settings()->site_connection_status());
637 EXPECT_EQ(WebsiteSettings:: 636 EXPECT_EQ(
638 SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM_MINOR, 637 WebsiteSettings::SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
639 website_settings()->site_identity_status()); 638 website_settings()->site_identity_status());
640 EXPECT_EQ(base::string16(), website_settings()->organization_name()); 639 EXPECT_EQ(base::string16(), website_settings()->organization_name());
641 EXPECT_EQ(IDR_PAGEINFO_WARNING_MINOR, 640 EXPECT_EQ(IDR_PAGEINFO_WARNING_MINOR,
642 WebsiteSettingsUI::GetIdentityIconID( 641 WebsiteSettingsUI::GetIdentityIconID(
643 website_settings()->site_identity_status())); 642 website_settings()->site_identity_status()));
644 } 643 }
645 644
646 TEST_F(WebsiteSettingsTest, HTTPSSHA1Major) {
647 security_info_.security_level = security_state::NONE;
648 security_info_.scheme_is_cryptographic = true;
649 security_info_.certificate = cert();
650 security_info_.cert_status = 0;
651 security_info_.security_bits = 81; // No error if > 80.
652 int status = 0;
653 status = SetSSLVersion(status, net::SSL_CONNECTION_VERSION_TLS1);
654 status = SetSSLCipherSuite(status, CR_TLS_RSA_WITH_AES_256_CBC_SHA256);
655 security_info_.connection_status = status;
656 security_info_.sha1_deprecation_status =
657 security_state::DEPRECATED_SHA1_MAJOR;
658
659 SetDefaultUIExpectations(mock_ui());
660 EXPECT_CALL(*mock_ui(), SetSelectedTab(WebsiteSettingsUI::TAB_ID_CONNECTION));
661
662 EXPECT_EQ(WebsiteSettings::SITE_CONNECTION_STATUS_ENCRYPTED,
663 website_settings()->site_connection_status());
664 EXPECT_EQ(WebsiteSettings::
665 SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM_MAJOR,
666 website_settings()->site_identity_status());
667 EXPECT_EQ(base::string16(), website_settings()->organization_name());
668 EXPECT_EQ(IDR_PAGEINFO_BAD,
669 WebsiteSettingsUI::GetIdentityIconID(
670 website_settings()->site_identity_status()));
671 }
672
673 #if !defined(OS_ANDROID) 645 #if !defined(OS_ANDROID)
674 TEST_F(WebsiteSettingsTest, NoInfoBar) { 646 TEST_F(WebsiteSettingsTest, NoInfoBar) {
675 SetDefaultUIExpectations(mock_ui()); 647 SetDefaultUIExpectations(mock_ui());
676 EXPECT_CALL(*mock_ui(), SetSelectedTab( 648 EXPECT_CALL(*mock_ui(), SetSelectedTab(
677 WebsiteSettingsUI::TAB_ID_PERMISSIONS)); 649 WebsiteSettingsUI::TAB_ID_PERMISSIONS));
678 EXPECT_EQ(0u, infobar_service()->infobar_count()); 650 EXPECT_EQ(0u, infobar_service()->infobar_count());
679 website_settings()->OnUIClosing(); 651 website_settings()->OnUIClosing();
680 EXPECT_EQ(0u, infobar_service()->infobar_count()); 652 EXPECT_EQ(0u, infobar_service()->infobar_count());
681 } 653 }
682 654
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 histograms.ExpectTotalCount(test.histogram_name, 2); 751 histograms.ExpectTotalCount(test.histogram_name, 2);
780 histograms.ExpectBucketCount( 752 histograms.ExpectBucketCount(
781 test.histogram_name, 753 test.histogram_name,
782 WebsiteSettings::WebsiteSettingsAction::WEBSITE_SETTINGS_OPENED, 1); 754 WebsiteSettings::WebsiteSettingsAction::WEBSITE_SETTINGS_OPENED, 1);
783 histograms.ExpectBucketCount(test.histogram_name, 755 histograms.ExpectBucketCount(test.histogram_name,
784 WebsiteSettings::WebsiteSettingsAction:: 756 WebsiteSettings::WebsiteSettingsAction::
785 WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED, 757 WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED,
786 1); 758 1);
787 } 759 }
788 } 760 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698