Layout avatar button

chrome/browser/ui/views/frame/minimize_button_metrics_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/minimize_button_metrics_win.h"
 
 #include "base/logging.h"
 #include "base/i18n/rtl.h"
 #include "base/win/windows_version.h"
 #include "dwmapi.h"
 #include "ui/base/win/shell.h"
 #include "ui/display/win/dpi.h"
 #include "ui/display/win/screen_win.h"
 #include "ui/gfx/geometry/point.h"
 
 namespace {
 
 // These constants were determined by manually adding various offsets
 // until the identity switcher was placed at the same location as before.
 // When a new or updated OS version is released, a new constant may need
 // to be added to this list and GetDefaultButtonBoundsOffset() is updated.
 const int kWin7ButtonBoundsPositionOffset = 1;
 const int kWin8ButtonBoundsPositionOffset = 10;
 const int kWin10ButtonBoundsPositionOffset = 6;
 const int kInvalidOffset = static_cast<int>(0x80000000);
 
+// This constant was determined manually by testing on windows 10.
+const int kWin10ButtonHeight = 30;
+const int kInvalidHeight = static_cast<int>(0x80000000);
+
 using base::win::GetVersion;
 using display::win::ScreenWin;
 
 int GetDefaultButtonBoundsOffset() {
   if (GetVersion() >= base::win::VERSION_WIN10)
     return kWin10ButtonBoundsPositionOffset;
   if (GetVersion() >= base::win::VERSION_WIN8)
     return kWin8ButtonBoundsPositionOffset;
   return kWin7ButtonBoundsPositionOffset;
 }
 
+int GetDefaultButtonHeight() {
+  return kWin10ButtonHeight;
+}
+
 }  // namespace
 
 // static
 int MinimizeButtonMetrics::last_cached_minimize_button_x_delta_ = 0;
 
 // static
 int MinimizeButtonMetrics::button_bounds_position_offset_ = kInvalidOffset;
 
+// statis
+int MinimizeButtonMetrics::button_bounds_height_ = kInvalidHeight;
+
 MinimizeButtonMetrics::MinimizeButtonMetrics()
     : hwnd_(nullptr),
       cached_minimize_button_x_delta_(last_cached_minimize_button_x_delta_),
       was_activated_(false) {
 }
 
 MinimizeButtonMetrics::~MinimizeButtonMetrics() {
 }
 
 void MinimizeButtonMetrics::Init(HWND hwnd) {
   DCHECK(!hwnd_);
   hwnd_ = hwnd;
 }
 
 void MinimizeButtonMetrics::OnHWNDActivated() {
   was_activated_ = true;
   // NOTE: we don't cache here as it seems only after the activate is the value
   // correct.
 }
 
+void MinimizeButtonMetrics::UpdateButtonBoundsSizes(const RECT& button_bounds,
+                             const RECT& window_bounds) const {
+//  LOG(ERROR) << "X BUTTON BOUNDS " << button_bounds.left << ", " << button_bounds.top << " - " << button_bounds.right - button_bounds.left << " x " << button_bounds.top - button_bounds.bottom;
+
+  if (button_bounds_position_offset_ != kInvalidOffset) {
+    return;
+  }
+  DCHECK_EQ(kInvalidHeight, button_bounds_height_);
+
+  if (button_bounds.left == button_bounds.right || button_bounds.top == button_bounds.left) {
+    return;
+  }
+  if (!was_activated_ || !IsWindowVisible(hwnd_)) {
+    return;
+  }
+
+  TITLEBARINFOEX info = { 0 };
+  info.cbSize = sizeof(info);
+  SendMessage(hwnd_, WM_GETTITLEBARINFOEX, 0,
+    reinterpret_cast<LPARAM>(&info));
+  if (info.rgrect[2].right == info.rgrect[2].left ||
+    (info.rgstate[2] & (STATE_SYSTEM_INVISIBLE | STATE_SYSTEM_OFFSCREEN |
+      STATE_SYSTEM_UNAVAILABLE))) {
+    return;
+  }
+  button_bounds_position_offset_ =
+    info.rgrect[2].left - (button_bounds.left + window_bounds.left);
+  button_bounds_height_ = button_bounds.bottom - button_bounds.top;
+}
+
 // This function attempts to calculate the odd and varying difference
 // between the results of DwmGetWindowAttribute with the
 // DWMWA_CAPTION_BUTTON_BOUNDS flag and the information from the
 // WM_GETTITLEBARINFOEX message. It will return an empirically determined
 // offset until the window has been activated and the message returns
 // valid rectangles.
 int MinimizeButtonMetrics::GetButtonBoundsPositionOffset(
     const RECT& button_bounds,
     const RECT& window_bounds) const {
-  if (button_bounds_position_offset_ == kInvalidOffset) {
-    if (!was_activated_ || !IsWindowVisible(hwnd_))
-      return GetDefaultButtonBoundsOffset();
-    TITLEBARINFOEX info = {0};
-    info.cbSize = sizeof(info);
-    SendMessage(hwnd_, WM_GETTITLEBARINFOEX, 0,
-                reinterpret_cast<LPARAM>(&info));
-    if (info.rgrect[2].right == info.rgrect[2].left ||
-        (info.rgstate[2] & (STATE_SYSTEM_INVISIBLE | STATE_SYSTEM_OFFSCREEN |
-                            STATE_SYSTEM_UNAVAILABLE)))
-      return GetDefaultButtonBoundsOffset();
-    button_bounds_position_offset_ =
-        info.rgrect[2].left - (button_bounds.left + window_bounds.left);
-  }
+  UpdateButtonBoundsSizes(button_bounds, window_bounds);
+  if (button_bounds_position_offset_ == kInvalidOffset)
+    return GetDefaultButtonBoundsOffset();
   return button_bounds_position_offset_;
 }
 
 int MinimizeButtonMetrics::GetMinimizeButtonOffsetForWindow() const {
   bool dwm_button_pos = false;
   POINT minimize_button_corner = {0};
   RECT button_bounds = {0};
   if (SUCCEEDED(DwmGetWindowAttribute(hwnd_, DWMWA_CAPTION_BUTTON_BOUNDS,
                                       &button_bounds, sizeof(button_bounds)))) {
     if (button_bounds.left != button_bounds.right) {
@@ skipping 83 matching lines @@
     cached_minimize_button_x_delta_ = minimize_button_offset;
   } else {
     RECT client_rect = {0};
     GetClientRect(hwnd_, &client_rect);
     cached_minimize_button_x_delta_ =
         client_rect.right - minimize_button_offset;
   }
   last_cached_minimize_button_x_delta_ = cached_minimize_button_x_delta_;
   return minimize_button_offset;
 }
+
+int MinimizeButtonMetrics::GetMinimizeButtonHeight() const {
+  if (button_bounds_height_ == kInvalidHeight) {
+    RECT button_bounds = { 0 };
+    if (SUCCEEDED(DwmGetWindowAttribute(hwnd_, DWMWA_CAPTION_BUTTON_BOUNDS,
+      &button_bounds, sizeof(button_bounds)))) {
+      // This converts the button coordinate into screen coordinates
+      // thus, ensuring that the identity switcher is placed in the
+      // same location as before. An additional constant is added because
+      // there is a difference between the caption button bounds and
+      // the values obtained through WM_GETTITLEBARINFOEX. This difference
+      // varies between OS versions, and no metric describing this difference
+      // has been located.
+      RECT window_bounds = { 0 };
+      if (GetWindowRect(hwnd_, &window_bounds)) {
+        UpdateButtonBoundsSizes(button_bounds, window_bounds);
+      }
+    }
+  }
+
+  if (button_bounds_height_ == kInvalidHeight)
+    return GetDefaultButtonHeight();
+  return button_bounds_height_;
+}