Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2616463004: Signal an error for File.lastModified on a directory (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Signal an error for File.lastModified on a directory fixes #28173 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1f6c914d670e5093f3f6a5160a46583503a8c4db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M runtime/bin/file_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +6 lines, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 11 months ago (2017-01-03 23:47:05 UTC) #2
siva
lgtm
3 years, 11 months ago (2017-01-04 01:54:22 UTC) #3
zra
3 years, 11 months ago (2017-01-04 15:50:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f6c914d670e5093f3f6a5160a46583503a8c4db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698