DevTools: Add types to all properties on SplitWidget

third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 33 matching lines @@
     this.registerRequiredCSS('ui/splitWidget.css');
 
     this.contentElement.classList.add('shadow-split-widget');
     this._mainElement =
         this.contentElement.createChild('div', 'shadow-split-widget-contents shadow-split-widget-main vbox');
     this._mainElement.createChild('content').select = '.insertion-point-main';
     this._sidebarElement =
         this.contentElement.createChild('div', 'shadow-split-widget-contents shadow-split-widget-sidebar vbox');
     this._sidebarElement.createChild('content').select = '.insertion-point-sidebar';
     this._resizerElement = this.contentElement.createChild('div', 'shadow-split-widget-resizer');
+    this._resizerElementSize = null;
 
     this._resizerWidget = new UI.SimpleResizerWidget();
     this._resizerWidget.setEnabled(true);
     this._resizerWidget.addEventListener(UI.ResizerWidget.Events.ResizeStart, this._onResizeStart, this);
     this._resizerWidget.addEventListener(UI.ResizerWidget.Events.ResizeUpdate, this._onResizeUpdate, this);
     this._resizerWidget.addEventListener(UI.ResizerWidget.Events.ResizeEnd, this._onResizeEnd, this);
 
     this._defaultSidebarWidth = defaultSidebarWidth || 200;
     this._defaultSidebarHeight = defaultSidebarHeight || this._defaultSidebarWidth;
     this._constraintsInDip = !!constraintsInDip;
+    this._resizeStartSizeDIP = 0;
     this._setting = settingName ? Common.settings.createSetting(settingName, {}) : null;
 
+    this._totalSizeCSS = 0;
+    this._totalSizeOtherDimensionCSS = 0;
+    /** @type {?UI.Widget} */
+    this._mainWidget = null;
+    /** @type {?UI.Widget} */
+    this._sidebarWidget = null;
+    this._animationFrameHandle = 0;
+    /** @type {?function()} */
+    this._animationCallback = null;
+    this._showHideSidebarButtonTitle = '';
+    /** @type {?UI.ToolbarButton} */
+    this._showHideSidebarButton = null;
+    this._isVertical = false;
+    this._sidebarMinimized = false;
+    this._detaching = false;
+    this._sidebarSizeDIP = -1;
+    this._savedSidebarSizeDIP = this._sidebarSizeDIP;
+    this._secondIsSidebar = false;
+    this._shouldSaveShowMode = false;
+    /** @type {?number} */
+    this._savedVerticalMainSize = null;
+    /** @type {?number} */
+    this._savedHorizontalMainSize = null;
+
     this.setSecondIsSidebar(secondIsSidebar);
 
     this._innerSetVertical(isVertical);
     this._showMode = UI.SplitWidget.ShowMode.Both;
+    this._savedShowMode = this._showMode;
 
     // Should be called after isVertical has the right value.
     this.installResizer(this._resizerElement);
   }
 
   /**
    * @return {boolean}
    */
   isVertical() {
     return this._isVertical;
@@ skipping 13 matching lines @@
   }
 
   /**
    * @param {boolean} isVertical
    */
   _innerSetVertical(isVertical) {
     this.contentElement.classList.toggle('vbox', !isVertical);
     this.contentElement.classList.toggle('hbox', isVertical);
     this._isVertical = isVertical;
 
-    delete this._resizerElementSize;
+    this._resizerElementSize = null;
     this._sidebarSizeDIP = -1;
     this._restoreSidebarSizeFromSettings();
     if (this._shouldSaveShowMode)
       this._restoreAndApplyShowModeFromSettings();
     this._updateShowHideSidebarButton();
     // FIXME: reverse SplitWidget.isVertical meaning.
     this._resizerWidget.setVertical(!isVertical);
     this.invalidateConstraints();
   }
 
   /**
    * @param {boolean=} animate
    */
   _updateLayout(animate) {
-    delete this._totalSizeCSS;  // Lazy update.
-    delete this._totalSizeOtherDimensionCSS;
+    this._totalSizeCSS = 0;  // Lazy update.
+    this._totalSizeOtherDimensionCSS = 0;
 
     // Remove properties that might affect total size calculation.
     this._mainElement.style.removeProperty('width');
     this._mainElement.style.removeProperty('height');
     this._sidebarElement.style.removeProperty('width');
     this._sidebarElement.style.removeProperty('height');
 
     this._innerSetSidebarSizeDIP(this._preferredSidebarSizeDIP(), !!animate);
   }
 
@@ skipping 50 matching lines @@
   }
 
   /**
    * @override
    * @param {!UI.Widget} widget
    */
   childWasDetached(widget) {
     if (this._detaching)
       return;
     if (this._mainWidget === widget)
-      delete this._mainWidget;
+      this._mainWidget = null;
     if (this._sidebarWidget === widget)
-      delete this._sidebarWidget;
+      this._sidebarWidget = null;
+    this.invalidateConstraints();
   }
 
   /**
    * @return {boolean}
    */
   isSidebarSecond() {
     return this._secondIsSidebar;
   }
 
   enableShowModeSaving() {
@@ skipping 57 matching lines @@
   }
 
   /**
    * @return {boolean}
    */
   isSidebarMinimized() {
     return this._sidebarMinimized;
   }
 
   /**
-   * @param {!UI.Widget} sideToShow
-   * @param {!UI.Widget} sideToHide
+   * @param {?UI.Widget} sideToShow
+   * @param {?UI.Widget} sideToHide
    * @param {!Element} shadowToShow
    * @param {!Element} shadowToHide
    * @param {boolean=} animate
    */
   _showOnly(sideToShow, sideToHide, shadowToShow, shadowToHide, animate) {
     this._cancelAnimation();
 
     /**
      * @this {UI.SplitWidget}
      */
     function callback() {
       if (sideToShow) {
         // Make sure main is first in the children list.
         if (sideToShow === this._mainWidget)
           this._mainWidget.show(this.element, this._sidebarWidget ? this._sidebarWidget.element : null);
         else
           this._sidebarWidget.show(this.element);
       }
       if (sideToHide) {
         this._detaching = true;
         sideToHide.detach();
-        delete this._detaching;
+        this._detaching = false;
       }
 
       this._resizerElement.classList.add('hidden');
       shadowToShow.classList.remove('hidden');
       shadowToShow.classList.add('maximized');
       shadowToHide.classList.add('hidden');
       shadowToHide.classList.remove('maximized');
       this._removeAllLayoutProperties();
       this.doResize();
     }
@@ skipping 182 matching lines @@
       this.dispatchEventToListeners(UI.SplitWidget.Events.SidebarSizeChanged, this.sidebarSize());
     }
   }
 
   /**
    * @param {boolean} reverse
    * @param {function()=} callback
    */
   _animate(reverse, callback) {
     var animationTime = 50;
-    this._animationCallback = callback;
+    this._animationCallback = callback || null;
 
     var animatedMarginPropertyName;
     if (this._isVertical)
       animatedMarginPropertyName = this._secondIsSidebar ? 'margin-right' : 'margin-left';
     else
       animatedMarginPropertyName = this._secondIsSidebar ? 'margin-bottom' : 'margin-top';
 
     var marginFrom = reverse ? '0' : '-' + UI.zoomManager.dipToCSS(this._sidebarSizeDIP) + 'px';
     var marginTo = reverse ? '-' + UI.zoomManager.dipToCSS(this._sidebarSizeDIP) + 'px' : '0';
 
@@ skipping 11 matching lines @@
 
     // 3. Configure and run animation
     this.contentElement.style.setProperty('transition', animatedMarginPropertyName + ' ' + animationTime + 'ms linear');
 
     var boundAnimationFrame;
     var startTime;
     /**
      * @this {UI.SplitWidget}
      */
     function animationFrame() {
-      delete this._animationFrameHandle;
+      this._animationFrameHandle = 0;
 
       if (!startTime) {
         // Kick animation on first frame.
         this.contentElement.style.setProperty(animatedMarginPropertyName, marginTo);
         startTime = window.performance.now();
       } else if (window.performance.now() < startTime + animationTime) {
         // Process regular animation frame.
         if (this._mainWidget)
           this._mainWidget.doResize();
       } else {
@@ skipping 12 matching lines @@
 
   _cancelAnimation() {
     this.contentElement.style.removeProperty('margin-top');
     this.contentElement.style.removeProperty('margin-right');
     this.contentElement.style.removeProperty('margin-bottom');
     this.contentElement.style.removeProperty('margin-left');
     this.contentElement.style.removeProperty('transition');
 
     if (this._animationFrameHandle) {
       this.contentElement.window().cancelAnimationFrame(this._animationFrameHandle);
-      delete this._animationFrameHandle;
+      this._animationFrameHandle = 0;
     }
     if (this._animationCallback) {
       this._animationCallback();
-      delete this._animationCallback;
+      this._animationCallback = null;
     }
   }
 
   /**
    * @param {number} sidebarSize
    * @param {boolean=} userAction
    * @return {number}
    */
   _applyConstraints(sidebarSize, userAction) {
     var totalSize = this._totalSizeDIP();
@@ skipping 20 matching lines @@
     var minMainSize = this.isVertical() ? constraints.minimum.width : constraints.minimum.height;
     if (!minMainSize)
       minMainSize = UI.SplitWidget.MinPadding;
     minMainSize *= zoomFactor;
 
     var preferredMainSize = this.isVertical() ? constraints.preferred.width : constraints.preferred.height;
     if (!preferredMainSize)
       preferredMainSize = UI.SplitWidget.MinPadding;
     preferredMainSize *= zoomFactor;
     var savedMainSize = this.isVertical() ? this._savedVerticalMainSize : this._savedHorizontalMainSize;
-    if (typeof savedMainSize !== 'undefined')
+    if (savedMainSize !== null)
       preferredMainSize = Math.min(preferredMainSize, savedMainSize * zoomFactor);
     if (userAction)
       preferredMainSize = minMainSize;
 
     // Enough space for preferred.
     var totalPreferred = preferredMainSize + preferredSidebarSize;
     if (totalPreferred <= totalSize)
       return Number.constrain(sidebarSize, preferredSidebarSize, totalSize - preferredMainSize);
 
     // Enough space for minimum.
@@ skipping 83 matching lines @@
     if (this.isVertical())
       this._savedVerticalMainSize = this._totalSizeDIP() - this._sidebarSizeDIP;
     else
       this._savedHorizontalMainSize = this._totalSizeDIP() - this._sidebarSizeDIP;
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onResizeEnd(event) {
-    delete this._resizeStartSizeDIP;
+    this._resizeStartSizeDIP = 0;
   }
 
   hideDefaultResizer() {
     this.uninstallResizer(this._resizerElement);
   }
 
   /**
    * @param {!Element} resizerElement
    */
   installResizer(resizerElement) {
@@ skipping 160 matching lines @@
   OnlySidebar: 'OnlySidebar'
 };
 
 /** @enum {symbol} */
 UI.SplitWidget.Events = {
   SidebarSizeChanged: Symbol('SidebarSizeChanged'),
   ShowModeChanged: Symbol('ShowModeChanged')
 };
 
 UI.SplitWidget.MinPadding = 20;